When viewing the details of `Dangerous tags were found in submitted content (fields).` I'm getting the PHP fatal error:
```
TypeError: Argument 1 passed to Drupal\security_review\Checks\Field::getEntityLink() must be an instance of Drupal\Core\Entity\Entity, instance of Drupal\node\Entity\Node given, called in security_review/src/Checks/Field.php on line 141 in Drupal\security_review\Checks\Field->getEntityLink() (line 166 of security_review/src/Checks/Field.php).
```

CommentFileSizeAuthor
#3 security_review-3127304-2.patch682 bytesdouggreen

Comments

jenlampton created an issue. See original summary.

jenlampton’s picture

jenlampton
she / her
commented
Title: PHP fatal when viewing details of » PHP fatal when viewing details of `Dangerous tags were found...`

Adding complete issue title.

douggreen’s picture

douggreen commented
StatusFileSize
new security_review-3127304-2.patch682 bytes

We need to use EntityInterface instead of Entity.

douggreen’s picture

douggreen commented

This was introduced in the very last commit #2988514: Field check gets fatal error when using Paragraphs (or other entity without edit or canonical routes) but that was 2 years ago.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Active » Needs review

Thanks for this fix, @douggreen!

  • greggles committed 7554a62 on 8.x-1.x authored by douggreen 
    Issue #3127304 by douggreen: PHP fatal when viewing details of `...
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Fixed

Now committed. Thanks for reporting the issue jenlampton and for fixing it, douggreen!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

smustgrave credited elimw.

smustgrave credited iyyappan.govind.

smustgrave credited PCate.

smustgrave’s picture

smustgrave commented
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Thanks for doing that, smustgrave. To explain the credit, those 3 folks worked on a duplicate issue at #3077541: TypeError: Argument 1 passed to Drupal\security_review\Checks\Field::getEntityLink().