Phpcs coding standard bugs [#3125196]

FILE: /opt/lampp/htdocs/drupal/modules/marco_polo/marco_polo.api.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
19 | ERROR | Type hint "array" missing for $response
----------------------------------------------------------------------

FILE: ...pp/htdocs/drupal/modules/marco_polo/src/Controller/MarcoPoloController.php
--------------------------------------------------------------------------------
FOUND 9 ERRORS AND 2 WARNINGS AFFECTING 11 LINES
--------------------------------------------------------------------------------
28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
29 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
30 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
31 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
32 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
96 | ERROR | [x] Blank lines are not allowed in a multi-line function
| | declaration
130 | ERROR | [x] Separate the @return and @throws sections by a blank line.
153 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: $submit_flag
163 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: $action
170 | ERROR | [ ] Parameter $submit_flag is not described in comment
179 | ERROR | [ ] Type hint "array" missing for $active_users
--------------------------------------------------------------------------------

FILE: /opt/lampp/htdocs/drupal/modules/marco_polo/marco_polo.module
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
42 | WARNING | [x] A comma should follow the last multiline array item. Found:
| | 1000
--------------------------------------------------------------------------------

Comment	File	Size	Author
#7	After patch applied 3125196.png	77.13 KB	riddhi.addweb
#2	3125196-2.patch	3.1 KB	neelam_wadhwani

Issue fork marco_polo-3125196

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3125196-phpcs-coding-standard changes, plain diff MR !1
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

6 April 2020 at 07:29

neelam_wadhwani created an issue. See original summary.

Comment #2

neelam_wadhwani commented 6 April 2020 at 07:30

Assigned:	neelam_wadhwani	» Unassigned
Status:	Needs work	» Needs review

Status	File	Size
new	3125196-2.patch	3.1 KB

KIndly review patch,

Comment #3

riddhi.addweb commented 22 July 2024 at 08:49

Status:

Needs review

» Needs work

I tried the #2 patch and it has been applied cleanly. But still, some errors are displayed:-

FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/marco_polo/marco_polo.routing.yml
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 7 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
-----------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/marco_polo/src/Controller/MarcoPoloController.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------
 11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheBackendInterface.
 95 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/marco_polo/marco_polo.module
-----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------