CommentFileSizeAuthor
#6 interdiff_4-6.txt2.22 KBsuresh prabhu parkala
#6 3121305-6.patch4.42 KBsuresh prabhu parkala
#4 3121305-4.patch6.09 KBsuresh prabhu parkala
#2 3121305-2.patch4.04 KBneslee canil pinto

Comments

Neslee Canil Pinto created an issue. See original summary.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3121305-2.patch4.04 KB
drugan’s picture

drugan commented
Status: Needs review » Needs work

@Neslee Canil Pinto

Please, inject the messenger service and replace the \Drupal::messenger() with $this->messenger.

suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Needs work » Needs review
StatusFileSize
new 3121305-4.patch6.09 KB

Please review!

drugan’s picture

drugan commented
Status: Needs review » Needs work

@Suresh Prabhu Parkala

Note that Drupal\Core\Action\ActionBase class already have the messenger service injected so please remove the use Drupal\Core\Messenger\MessengerTrait; entry from all *Action classes.

suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Needs work » Needs review
StatusFileSize
new 3121305-6.patch4.42 KB
new interdiff_4-6.txt2.22 KB

Please review!

drugan’s picture

drugan commented
Status: Needs review » Fixed

Thanks guys!

Anyone willing to help with a more serious issue to make our module fully compatible with Drupal 9... - you are welcome:

#3146793: Drupal 9 compatibility fixes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.