See https://wiki.php.net/rfc/deprecate_curly_braces_array_access.

CommentFileSizeAuthor
#10 search_config-curly_brace_syntax_for-3121046-10-8.x.patch542 byteshargobind
search_config-php-7.4-curly-braces.patch463 bytesjacob.embree

Issue fork search_config-3121046

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jacob.embree created an issue. See original summary.

hargobind’s picture

hargobind
he/him
Location Austin, Texas
commented
Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community

Works like a charm. RTBC.

Changing the priority to Major since this patch fixes PHP errors.

rajatc’s picture

rajatc commented

This patch https://www.drupal.org/files/issues/2020-03-19/search_config-php-7.4-cur... works for me for PHP 7.4 compatibility warnings.

delosreyesa’s picture

delosreyesa commented

Patch works. Please merge it in.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

This is important, could any maintainer please merge this! 7.3 is EOL!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

PS: And please create a new release afterwards!

mkindred’s picture

mkindred commented

This patch fixed my fatal error running on PHP 8.1.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue tags: +PHP 8.1
poker10’s picture

poker10 commented

I have tested this and using the patch in dozens of websites for more than a half year without any problems.. It definitely works and looks good! +1 to RTBC.

hargobind’s picture

hargobind
he/him
Location Austin, Texas
commented
StatusFileSize
new search_config-curly_brace_syntax_for-3121046-10-8.x.patch542 bytes

Here's a patch for the 8.x branch. It's essentially the same code change as the 7.x, just a 1-line fix.

Anybody opened merge request !1

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Prepared MR's based on the patches for both branches. Thanks! :)

kburakozdemir’s picture

kburakozdemir commented

+1. This patch works for me on Drupal 7.93 and 8.0.26. Thanks.

  • poker10 committed 985298ce on 7.x-1.x authored by jacob.embree 
    Issue #3121046 by jacob.embree: Curly brace syntax for accessing array...
poker10’s picture

poker10 commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x-1.x branch. Closing this as fixed for now.

I do not know much about the state of the 8.x branch, as there is no release yet. But I think if needed, this can be committed also to the 8.x-1.x.

I will roll-out a new release of the 7.x branch soon (probably RC first, as there are some commits which were not released for 8 years).

Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

AstonVictor closed merge request !1