If the selected revision is not changed, the Latest revision radio remains the default checked option, then after selecting a Transition from the dropdown, the Recreate pending revision (recreate_non_default_head) checkbox is unchecked. This checkbox should always be checked if the user has not made an explicit choice to uncheck it.

CommentFileSizeAuthor
#6 3120526-pending-checkbox-buggy-ajax-state-6.patch3.22 KBdpi
#5 3120526-pending-checkbox-buggy-ajax-state-5.patch3.21 KBdpi
#3 3120526-pending-checkbox-buggy-ajax-state.patch2.83 KBdpi

Comments

dpi created an issue. See original summary.

dpi’s picture

dpi
Location Perth, Australia
commented
Related issues: +#1100170: Checkboxes default value is ignored by forms system during processing of AJAX request
dpi’s picture

dpi
Location Perth, Australia
commented
Assigned: dpi » Unassigned
Status: Active » Needs review
StatusFileSize
new 3120526-pending-checkbox-buggy-ajax-state.patch2.83 KB
dpi’s picture

dpi
Location Perth, Australia
commented

Patch reworks so checkbox is not reliant on AJAX, Javascript is much more predictable here.

dpi’s picture

dpi
Location Perth, Australia
commented
StatusFileSize
new 3120526-pending-checkbox-buggy-ajax-state-5.patch3.21 KB

Ninja removal of AJAX handler.

dpi’s picture

dpi
Location Perth, Australia
commented
StatusFileSize
new 3120526-pending-checkbox-buggy-ajax-state-6.patch3.22 KB

Fixing bad diff

  • dpi committed 7fe0cf3 on 8.x-1.x 
    Issue #3120526 by dpi: Recreate pending revision default unchecked if...
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.