Add core_version_requirement: ^8 || ^9 to imageapi_optimize.info.yml to designate that the module is compatible with Drupal 9. See https://www.drupal.org/node/3070687.

CommentFileSizeAuthor
#13 interdiff-3117904-drupal-9-10-13.txt630 bytesdpi
#13 3117904-drupal-9-13.patch5.24 KBdpi
#12 8.8.2-or-higher.patch623 bytesNickDickinsonWilde
#12 under-8.8.2.patch630 bytesNickDickinsonWilde
#10 interdiff-3117904-8-10-do-not-test.diff1.62 KBDaniel Korte
#10 drupal9-readiness-3117904-10.patch4.62 KBDaniel Korte
#8 drupal9-readiness-3117904-8.patch2.68 KBmo_farhaz
#6 drupal9-readiness-3117904-6.patch1.5 KBmo_farhaz
#3 3117904-3.patch470 bytesmo_farhaz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mo_farhaz created an issue. See original summary.

mo_farhaz’s picture

mo_farhaz CreditAttribution: mo_farhaz at Specbee commented
Assigned: mo_farhaz » Unassigned
mo_farhaz’s picture

mo_farhaz CreditAttribution: mo_farhaz at Specbee commented
Status: Active » Needs review
FileSize
3117904-3.patch470 bytes

Updated core requirement version compatibility. please review it.

mo_farhaz’s picture

mo_farhaz CreditAttribution: mo_farhaz at Specbee commented
Title: extends deprecated interface » Drupal 9 readiness
Issue summary: View changes
Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones at ComputerMinds commented
Status: Needs review » Needs work

Thanks for the issue and the patch, but from my understanding because we're using the deprecated interface we're explicity not Drupal 9 compatible and Drupal 8 compatible? We'd need a Drupal 9 branch that removes the deprecated interface use.

mo_farhaz’s picture

mo_farhaz CreditAttribution: mo_farhaz at Specbee commented
Status: Needs work » Needs review
FileSize
drupal9-readiness-3117904-6.patch1.5 KB

removed deprecated interface ConfigurablePluginInterface and implemented ConfigurableInterface and DependentPluginInterface.
please review it.

Steven Brown’s picture

Steven Brown CreditAttribution: Steven Brown as a volunteer commented
Status: Needs review » Active

Ran drupal-check against bb665be. Here is an error not listed in the patch above.

 ------ ----------------------------------------------------------------
  Line   tests/src/Kernel/ImageOptimizePipelineTest.php
 ------ ----------------------------------------------------------------
  184    Call to deprecated function file_default_scheme():
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use
         \Drupal::config('system.file')->get('default_scheme') instead.
  203    Call to deprecated function file_default_scheme():
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use
         \Drupal::config('system.file')->get('default_scheme') instead.
 ------ ----------------------------------------------------------------
mo_farhaz’s picture

mo_farhaz CreditAttribution: mo_farhaz at Specbee commented
Status: Active » Needs review
FileSize
drupal9-readiness-3117904-8.patch2.68 KB

deprecated function file_default_scheme() replaced with \Drupal::config('system.file')->get('default_scheme').
review the patch

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for Drupal Ukraine Community, GOLEMS GABB commented
Status: Needs review » Reviewed & tested by the community

Looks good for me. All Drupal deprecations covered and key added in info file.

Daniel Korte’s picture

Daniel Korte
he/him
Primary language English
Location Brooklyn, NY
CreditAttribution: Daniel Korte commented
Status: Reviewed & tested by the community » Needs review
FileSize
drupal9-readiness-3117904-10.patch4.62 KB
interdiff-3117904-8-10-do-not-test.diff1.62 KB

The service "entity.manager" is deprecated too. See #2894261: Deprecated service entity.manager needs to be replaced with entity_type.manager in ContentEntityForm

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones at ComputerMinds commented 
+++ b/src/ImageAPIOptimizeProcessorInterface.php
@@ -17,7 +16,7 @@ use Drupal\Component\Plugin\PluginInspectionInterface;
-interface ImageAPIOptimizeProcessorInterface extends PluginInspectionInterface, ConfigurableInterface, DependentPluginInterface, ConfigurablePluginInterface {
+interface ImageAPIOptimizeProcessorInterface extends PluginInspectionInterface, ConfigurableInterface, DependentPluginInterface {

These lines represent an API break, so we'll hold off on that and do a quick version 3 that's Drupal 8/9 compatible I reckon.

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde as a volunteer and at Taoti Creative commented
Status: Needs review » Reviewed & tested by the community
FileSize
under-8.8.2.patch630 bytes
8.8.2-or-higher.patch623 bytes

Works for me
One slight change is needed - depending on whether the new release version is set to support Drupal 8.8.2 or above only, the test module needs the core version removed, or if supporting below Drupal 8.8.2, a specific core_version_requirements line added.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi at PreviousNext commented
Category: Bug report » Task
Priority: Minor » Major
FileSize
3117904-drupal-9-13.patch5.24 KB
interdiff-3117904-drupal-9-10-13.txt630 bytes

Patched in 12 into 10. The decision was already made as a part of that patch.

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones at ComputerMinds commented
Version: 8.x-2.x-dev » 8.x-3.x-dev

  • Steven Jones committed 704e68a on 8.x-3.x 
    Issue #3117904 by mo_farhaz, Daniel Korte, NickDickinsonWilde, dpi,...
Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones at ComputerMinds commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x-3.x.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi at PreviousNext commented

@Steven Jones reckon we can switch to semver if its going to be a new major version?

(it will need to be a 4.x now, since 8.x-3.x was created..)

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones at ComputerMinds commented

Yeah, sorry about that!

Making the switch now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.