Closed (fixed)
Project:
Image Optimize
Version:
8.x-3.x-dev
Component:
Code
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
5 Mar 2020 at 05:09 UTC
Updated:
18 Jun 2020 at 07:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mo_farhaz commentedComment #3
mo_farhaz commentedUpdated core requirement version compatibility. please review it.
Comment #4
mo_farhaz commentedComment #5
steven jones commentedThanks for the issue and the patch, but from my understanding because we're using the deprecated interface we're explicity not Drupal 9 compatible and Drupal 8 compatible? We'd need a Drupal 9 branch that removes the deprecated interface use.
Comment #6
mo_farhaz commentedremoved deprecated interface ConfigurablePluginInterface and implemented ConfigurableInterface and DependentPluginInterface.
please review it.
Comment #7
Steven Brown commentedRan drupal-check against
bb665be. Here is an error not listed in the patch above.Comment #8
mo_farhaz commenteddeprecated function file_default_scheme() replaced with \Drupal::config('system.file')->get('default_scheme').
review the patch
Comment #9
volegerLooks good for me. All Drupal deprecations covered and key added in info file.
Comment #10
daniel korteThe service "entity.manager" is deprecated too. See #2894261: Deprecated service entity.manager needs to be replaced with entity_type.manager in ContentEntityForm
Comment #11
steven jones commentedThese lines represent an API break, so we'll hold off on that and do a quick version 3 that's Drupal 8/9 compatible I reckon.
Comment #12
nickdickinsonwildeWorks for me
One slight change is needed - depending on whether the new release version is set to support Drupal 8.8.2 or above only, the test module needs the core version removed, or if supporting below Drupal 8.8.2, a specific core_version_requirements line added.
Comment #13
dpiPatched in 12 into 10. The decision was already made as a part of that patch.
Comment #14
steven jones commentedComment #16
steven jones commentedCommitted to 8.x-3.x.
Comment #17
dpi@Steven Jones reckon we can switch to semver if its going to be a new major version?
(it will need to be a 4.x now, since 8.x-3.x was created..)
Comment #18
steven jones commentedYeah, sorry about that!
Making the switch now.