Looks like the module has no deprecated code usages, so we just need to mark it as compatible with D9.

So, add core_version_requirement: ^8 || ^9 to all info.yml files,
https://www.drupal.org/node/3070687.

CommentFileSizeAuthor
#2 3117692-2.patch650 bytesDeeksha B

Issue fork download-3117692

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 3117692-mark-as-compatible Comparecompare
  • 8.x-2.x Comparecompare
About issue forks

Comments

Deeksha B created an issue. See original summary.

Deeksha B’s picture

Deeksha B commented
Assigned: Deeksha B » Unassigned
Status: Active » Needs review
StatusFileSize
new 3117692-2.patch650 bytes

Please review the patch.

davidiio made their first commit to this issue’s fork.

johan den hollander’s picture

johan den hollander commented

This patch looks fine. Would be nice if this makes it into a new release!

johan den hollander’s picture

johan den hollander commented
Status: Needs review » Reviewed & tested by the community
gagarine’s picture

gagarine commented

I contacted Jesse Mortenson (last maintainer with a commit) to notify him about this issue. Let's see if he can do somethings.

gagarine’s picture

gagarine commented

Would be nice to commit #3140264: Automated Drupal Rector fixes also.

gagarine’s picture

gagarine commented
Status: Reviewed & tested by the community » Active

The patch seem wrong to me. It should be done on the 8-dev branch not the 7-dev.

But it's so easy, I think the maintainer can directly edit and commit.

gagarine’s picture

gagarine commented

Also on the DownloadLinkFormatter.php line 44 we need to use the service like that: 

   $uri = $fileEntity->getFileUri();
              if (\Drupal::service('stream_wrapper_manager')->isValidUri($uri)) {
                $valid_file_found = TRUE;
                $fname = $items->getName();
              }
greenmachine’s picture

greenmachine commented

Howdy folks - I'm afraid I am not involved in the Drupal community these days. In fact I have not been coding in PHP for a couple years. If there is someone here who wants to take over maintainership I am happy to hand it over.

gagarine’s picture

gagarine commented

hi greenmachine, thanks for the clarification. I'm not super involved in Drupal has I was in the past. But I still use it for some project. I could take over the maintainership temporarily in order to quickly publish a stable Drupal 9 version.

In the meantime, I propose to open a new issue "looking for maintainer" to find someone for the long term support of this module.

greenmachine’s picture

greenmachine commented

OK I have added you as a maintainer. I think this module already has an open for maintainer issue: https://www.drupal.org/project/download/issues/3237197

I'm going to drop myself as a maintainer. Good luck y'all!

gagarine’s picture

gagarine commented

Cool. I will create a release in the following days.

  • gagarine committed 4f4f16b on 8.x-2.x authored by Deeksha B 
    Issue #3117692 by davidiio, Deeksha B, gagarine: Mark as compatible with...
gagarine’s picture

gagarine commented
Status: Active » Fixed

There is now a release candidate compatible with D8 and D9

gagarine’s picture

gagarine commented
Version: 8.x-2.x-dev » 3.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.