Thinking this might be related to some old data, I deleted all Webform submissions, but I still get it with no submissions.

Notice: Undefined index: licensor in Drupal\views\Plugin\views\filter\FilterPluginBase->acceptExposedInput() (line 1381 of core\modules\views\src\Plugin\views\filter\FilterPluginBase.php).

Drupal\views\Plugin\views\filter\FilterPluginBase->acceptExposedInput(Array) (Line: 177)
Drupal\webform_views\Plugin\views\filter\WebformSubmissionFieldFilter->acceptExposedInput(Array) (Line: 159)
Drupal\views\Form\ViewsExposedForm->submitForm(Array, Object)
call_user_func_array(Array, Array) (Line: 111)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 51)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 590)
Drupal\Core\Form\FormBuilder->processForm('views_exposed_form', Array, Object) (Line: 319)
Drupal\Core\Form\FormBuilder->buildForm('\Drupal\views\Form\ViewsExposedForm', Object) (Line: 135)
Drupal\views\Plugin\views\exposed_form\ExposedFormPluginBase->renderExposedForm() (Line: 1238)
Drupal\views\ViewExecutable->build() (Line: 390)
Drupal\views\Plugin\views\display\PathPluginBase->execute() (Line: 180)
Drupal\views\Plugin\views\display\Page->execute() (Line: 1630)
Drupal\views\ViewExecutable->executeDisplay('monitoring_visits', Array) (Line: 77)
Drupal\views\Element\View::preRenderViewElement(Array)
call_user_func(Array, Array) (Line: 378)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 195)
Drupal\Core\Render\Renderer->render(Array, ) (Line: 226)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 582)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 227)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object) (Line: 117)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object)
call_user_func(Array, Object, 'kernel.view', Object) (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('kernel.view', Object) (Line: 156)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 693)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
CommentFileSizeAuthor
#6 3115645-WebformSubmissionSelectFilter.patch691 bytesgord.fisch

Issue fork webform_views-3115645

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

NancyDru created an issue. See original summary.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

I get this twice when I run the View.

That might have been the name of a field early on in the form design, but it is not currently a field in either form that is being referenced.

I have also tried reporting on each one of the form type separately and I still see this twice. Furthermore, if I point the view at the Contact form, I still get this.

gord.fisch’s picture

gord.fisch commented

I am getting this same behavior.
I tried to edit the 'Filter identifier'. Now I can't get rid of the error that the old filter name is missing

Notice: Undefined index: webform_submission_value_9 in Drupal\webform_views\Plugin\views\filter\WebformSubmissionSelectFilter->acceptExposedInput() (line 90 of modules/contrib/webform_views/src/Plugin/views/filter/WebformSubmissionSelectFilter.php).

Drupal\webform_views\Plugin\views\filter\WebformSubmissionSelectFilter->acceptExposedInput(Array) (Line: 192)
Drupal\views\Form\ViewsExposedForm->submitForm(Array, Object)
call_user_func_array(Array, Array) (Line: 114)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 52)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 591)

gord.fisch’s picture

gord.fisch commented

I looked at line 90 of modules/contrib/webform_views/src/Plugin/views/filter/WebformSubmissionSelectFilter.php
The surrounding function is:

public function acceptExposedInput($input) {
$accept = parent::acceptExposedInput($input);
$identifier = $this->options['expose']['identifier'];
if ($input[$identifier] == self::ALL) {
return FALSE;
}
return $accept;
}

If we just add an isset(), the error disappears.

public function acceptExposedInput($input) {
$accept = parent::acceptExposedInput($input);
$identifier = $this->options['expose']['identifier'];
if (isset($input[$identifier]) && $input[$identifier] == self::ALL) {
return FALSE;
}
return $accept;
}

I do not know why it comes up or any consequences.
Also, never made a patch so I will just propose this for now.

gord.fisch’s picture

gord.fisch commented

I looked at line 90 of modules/contrib/webform_views/src/Plugin/views/filter/WebformSubmissionSelectFilter.php
The surrounding function is:

public function acceptExposedInput($input) {
  $accept = parent::acceptExposedInput($input);
  $identifier = $this->options['expose']['identifier'];
  if ($input[$identifier] == self::ALL) {
    return FALSE;
  }
  return $accept;
}

If we just use isset() the error disappears.

public function acceptExposedInput($input) {
  $accept = parent::acceptExposedInput($input);
  $identifier = $this->options['expose']['identifier'];
  if (isset($input[$identifier]) && $input[$identifier] == self::ALL) {
    return FALSE;
  }
  return $accept;
}

I do not know why it comes up or any consequences.
Also, never made a patch so I will just propose this for now.

gord.fisch’s picture

gord.fisch commented
Status: Active » Needs review
StatusFileSize
new 3115645-WebformSubmissionSelectFilter.patch691 bytes

I made a patch for this.
In file /src/Plugin/views/filter/WebformSubmissionSelectFilter.php

In public function acceptExposedInput($input) {

changed
if ($input[$identifier] == self::ALL) {
to
if (isset($input[$identifier]) && $input[$identifier] == self::ALL) {

tested locally. It stops error
Notice: Undefined index: in Drupal\webform_views\Plugin\views\filter\WebformSubmissionSelectFilter->acceptExposedInput() (line 90 of modules/contrib/webform_views/src/Plugin/views/filter/WebformSubmissionSelectFilter.php).

bacon made their first commit to this issue’s fork.

bacon’s picture

bacon commented

The patch in #6 worked for me.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Needs review » Reviewed & tested by the community

Thanks for your contribution.

  • VladimirAus committed ec9e9ef on 8.x-5.x 
    Issue #3115645 by gord.fisch, bacon, NancyDru, VladimirAus: Undefined...
vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.