Problem/Motivation

It seems like core/themes/bartik/templates/node.html.twig is referencing a Claro library instead of a Bartik library.

Proposed resolution

Reference a Bartik template instead of Claro.

Remaining tasks

CommentFileSizeAuthor
#2 3115153-2.patch451 byteslauriii
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Active » Needs review
FileSize
3115153-2.patch451 bytes
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Title: Follow-up to #3113608: Incorrect reference in Bartik libraries » Follow-up to #3113608: Bartik template incorrectly referencing Claro library
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Issue summary: View changes
Hardik_Patel_12’s picture

Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 for Drupal India Association commented
Status: Needs review » Reviewed & tested by the community

LGTM, +1 RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Related issues: +#3113608: Add copies of Classy templates to core themes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

How come tests don't find this?

Committed and pushed 02d5e653f9 to 9.0.x and e9a0e67164 to 8.9.x. Thanks!

  • alexpott committed 02d5e65 on 9.0.x 
    Issue #3115153 by lauriii: Follow-up to #3113608: Bartik template...

  • alexpott committed e9a0e67 on 8.9.x 
    Issue #3115153 by lauriii: Follow-up to #3113608: Bartik template...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented

@alexpott I don't think we have tests ensuring attach_library calls are referring to correct theme, we have tests ensuring that attach_library doesn't refer to libraries in Classy.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented

So if \Drupal\FunctionalTests\Theme\BartikTest had visited a node then we would have seen an error?

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented

Yes, we would see an error assuming that Claro wasn't enabled on that test.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.