CR: https://www.drupal.org/node/3112907

Either update tests or add the Simpletest contrib module as instructed in Change record.

CommentFileSizeAuthor
#17 interdiff-3114798-15-17.txt12.37 KBrpsu
#17 3114798-tests-for-d9-17.patch18.23 KBrpsu
#15 interdiff-3114798-13-15.txt12.35 KBrpsu
#15 3114798-tests-for-d9-15.patch12.25 KBrpsu
#13 3114798-tests-for-d9-13.patch18.23 KBrpsu
#12 3114798-tests-for-d9-12.patch553 bytesrpsu
#10 interdiff-3114798-8-10.txt1.55 KBrpsu
#10 3114798-tests-for-d9-10.patch19.63 KBrpsu
#8 interdiff-3114798-3-8.txt13.55 KBrpsu
#8 3114798-tests-for-d9-8.patch18.23 KBrpsu
#6 interdiff-3114798-3-6.txt13.85 KBrpsu
#6 3114798-tests-for-d9-6.patch18.53 KBrpsu
#3 3114798-tests-for-d9-3.patch5.32 KBrpsu

Comments

rpsu created an issue. See original summary.

rpsu’s picture

rpsu
he/him
Primary language Finnish
commented
Issue summary: View changes
rpsu’s picture

rpsu
he/him
Primary language Finnish
commented
StatusFileSize
new 3114798-tests-for-d9-3.patch5.32 KB

Moved tests to new location (with new namespace), added default theme, removed an non-testing -test as unnecessary.

rpsu’s picture

rpsu
he/him
Primary language Finnish
commented
Status: Active » Needs review

Needs review to kick off tests

Status: Needs review » Needs work

The last submitted patch, 3: 3114798-tests-for-d9-3.patch, failed testing. View results

rpsu’s picture

rpsu
he/him
Primary language Finnish
commented
StatusFileSize
new 3114798-tests-for-d9-6.patch18.53 KB
new interdiff-3114798-3-6.txt13.85 KB

Remove t() calls, change @group name to module machine name.

rpsu’s picture

rpsu
he/him
Primary language Finnish
commented
Status: Needs work » Needs review
rpsu’s picture

rpsu
he/him
Primary language Finnish
commented
StatusFileSize
new 3114798-tests-for-d9-8.patch18.23 KB
new interdiff-3114798-3-8.txt13.55 KB

Remove parse errors.

Status: Needs review » Needs work

The last submitted patch, 8: 3114798-tests-for-d9-8.patch, failed testing. View results

rpsu’s picture

rpsu
he/him
Primary language Finnish
commented
Status: Needs work » Needs review
StatusFileSize
new 3114798-tests-for-d9-10.patch19.63 KB
new interdiff-3114798-8-10.txt1.55 KB

Trying with no drupalci.yml file

Status: Needs review » Needs work

The last submitted patch, 10: 3114798-tests-for-d9-10.patch, failed testing. View results

rpsu’s picture

rpsu
he/him
Primary language Finnish
commented
Status: Needs work » Needs review
StatusFileSize
new 3114798-tests-for-d9-12.patch553 bytes

Trying with drupalci.yml file removed *before* this patch in branch 2.0.x.

Patch is the same as in #10 apart from the removal of drupalci.yml file.

rpsu’s picture

rpsu
he/him
Primary language Finnish
commented
StatusFileSize
new 3114798-tests-for-d9-13.patch18.23 KB

Probably diff withough --stat works better for patching. Trying again.

Status: Needs review » Needs work

The last submitted patch, 13: 3114798-tests-for-d9-13.patch, failed testing. View results

rpsu’s picture

rpsu
he/him
Primary language Finnish
commented
Status: Needs work » Needs review
StatusFileSize
new 3114798-tests-for-d9-15.patch12.25 KB
new interdiff-3114798-13-15.txt12.35 KB

Reverting deletion of the old simpletest tests.

tr’s picture

tr commented
Version: 8.x-1.x-dev » 2.0.x-dev

The problem is because Drupal 9 requires MySql 5.7.8+. Your tests are failing because you were running them with MySql 5.6.

I retested your patch in #13 and you can see it now works with MySql 5.7.

rpsu’s picture

rpsu
he/him
Primary language Finnish
commented
StatusFileSize
new 3114798-tests-for-d9-17.patch18.23 KB
new interdiff-3114798-15-17.txt12.37 KB

Once more, moving tests to new location and changing them to extend from BrowserTestBase

  • rpsu committed b763885 on 2.0.x 
    Issue #3114798 by rpsu, TR: Tests with D9 are broken due to Simpletest...
rpsu’s picture

rpsu
he/him
Primary language Finnish
commented
Status: Needs review » Fixed

tests passing, closing the issue. Thanks @TR!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.