Problem/Motivation

Certain token types (current-page, user) can create major caching problems since their bubbleable metadata is not added to the imagefield_tokens render array.

Proposed resolution

Update the formatter such that bubbleable metadata from the tokesn is added to the render array.

Remaining tasks

Patch to follow.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

TBD

CommentFileSizeAuthor
#5 imagefield_tokens--cache--3112488--4.patch3.38 KBakyrylenko
#4 imagefield_tokens--cache--3112488--3.patch3.53 KBdanflanagan8
#2 entityreference_extensions--plus-formatter--3110486--13.patch38.42 KBdanflanagan8

Comments

danflanagan8 created an issue. See original summary.

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
StatusFileSize
new entityreference_extensions--plus-formatter--3110486--13.patch38.42 KB

Here's a patch that I think adds the right cacheable metadata to the render array, accounting for tokens that have been replaced. I also updated a test so this update has test coverage.
I uploaded the wrong patch here. Please ignore.

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
Status: Active » Needs review
danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
StatusFileSize
new imagefield_tokens--cache--3112488--3.patch3.53 KB

Here's the correct patch. I believe it resolves this issue and adds test coverage.

akyrylenko’s picture

akyrylenko commented
StatusFileSize
new imagefield_tokens--cache--3112488--4.patch3.38 KB

↑ Please ignore my patch above, it's related to wrong branch ↑

Hi there,

Patch works for me.
Tested on D8.8.1, module version 8.x-2.x

akyrylenko’s picture

akyrylenko commented
ysamoylenko’s picture

ysamoylenko commented
Status: Needs review » Reviewed & tested by the community

Hello @danflanagan8,

Thanks for your great patch.

@akyrylenko, thank you for review.

The patch will be committed soon.

ysamoylenko’s picture

ysamoylenko commented
Status: Reviewed & tested by the community » Fixed

The patch was committed.
Thanks everyone for your contribution to the module development.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.