Update patch that no longer applies

I'm also experiencing this problem.

In my case, I'm using vaimo/composer-patches, which chokes on the original patch (2869592-remove-update-warning-7.patch).

Bottom line is that the original patch has garbage at the end of it.

For example, note the "Hmm... Ignoring the trailing garbage" line in the output from patch (run from docroot/core):

$ curl -s 'https://www.drupal.org/files/issues/2869592-remove-update-warning-7.patch' | /usr/bin/patch -t --verbose -p'2' --no-backup-if-mismatch --dry-run 
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|From c7b3da0db33803b01f3813797283821072288b94 Mon Sep 17 00:00:00 2001
|From: Jakob Perry <japerry@45640.no-reply.drupal.org>
|Date: Mon, 22 May 2017 14:04:49 -0400
|Subject: [PATCH] Issue 2869592
|
|---
| core/modules/system/system.install | 2 +-
| 1 file changed, 1 insertion(+), 1 deletion(-)
|
|diff --git a/core/modules/system/system.install b/core/modules/system/system.install
|index 56ce685..5daf6a8 100644
|--- a/core/modules/system/system.install
|+++ b/core/modules/system/system.install
--------------------------
Patching file modules/system/system.install using Plan A...
Reversed (or previously applied) patch detected!  Assuming -R.
Hunk #1 succeeded at 948 with fuzz 1 (offset 131 lines).
Hmm...  Ignoring the trailing garbage.
done

That garbage might be what's causing the patch to fail on the coworker's machine.

Workaround

• Use vaimo/composer-patches in your project instead of cweagans/composer-patches.
• Tell the patcher to exclude the corresponding patch in drupal/lightning_core.
• Apply the rerolled patch (#34) in your project's composer.json.

Example code snippet for the project's composer.json:

        "patches-exclude": {
            "drupal/lightning_core": [
                "2869592-remove-update-warning-7.patch"
            ]
        },
        "patches": {
            "drupal/core": {
                "2869592 - Disabled update module shouldn't produce a status report warning": "https://www.drupal.org/files/issues/2020-02-07/2869592-remove-update-warning-34.patch"
            }
        }

With this workaround, the broken patch is skipped and composer install finishes without errors for me.

Update

Might also need to remove this line from your composer.json.

"composer-exit-on-patch-failure": true,

Composer may install cweagans/composer-patches if required by any dependencies, at least with fresh installations.

With that line in place, a failure from cweagans/composer-patches may cause composer to abort before vaimo/composer-patches ever has a chance to run.

I have also experienced this issue, doing --verbose argument when running composer install/update helped realze that the patch tool was not available on the host. Hence it failed upon the first patch. Not related to the actual patch.

I had a number of patches that I needed to ignore but their location moved from the lightning_core composer.json to the acquia/lightning profile at docroot/profile/contrib/lightning/composer.json.

I had to add exclude those using this in my root composer.json:

    "patches-ignore": {
            "acquia/lightning": {
                "drupal/core": {
                    "[subprofile support] 1356276 - Allow profiles to define a base/parent profile and load them in the correct order": "https://www.drupal.org/files/issues/2019-11-05/1356276-531-8.8.x-4.patch",
                    "[subprofile support] 2914389 - Allow profiles to exclude dependencies of their parent": "https://www.drupal.org/files/issues/2018-07-09/2914389-8-do-not-test.patch"
                }
            }
        },

If you are having issues ignoring a patch try and find all the locations that are adding it.