The module has a few tests that, depending on the outcome of #3063887: Support PHPUnit 8 in Drupal 9, drop support for PHPUnit 7, may need to be updated:

 ------ -------------------------------------------------------------------------------------- 
  Line   contrib/focal_point/tests/src/Unit/Effects/FocalPointEffectsTest.php                  
 ------ -------------------------------------------------------------------------------------- 
  44     Call to deprecated method assertAttributeEquals() of class PHPUnit\Framework\Assert:  
         https://github.com/sebastianbergmann/phpunit/issues/3338                              
  45     Call to deprecated method assertAttributeEquals() of class PHPUnit\Framework\Assert:  
         https://github.com/sebastianbergmann/phpunit/issues/3338                              
 ------ --------------------------------------------------------------------------------------
CommentFileSizeAuthor
#3 prepare-the-module-for-d9-3109593-#3.patch1.69 KBmalte.koelle

Comments

svenryen created an issue. See original summary.

jenlampton’s picture

jenlampton
she / her
commented

I believe that if you add drupal 9 as an option to the composer.json file in this project you can get a nice little Compatible with Drupal 9 badge in the Project information section on the module page.

Screenshot of the Project information section with Compatible with Drupal 9 highlighted

Below is a code sample from a module that has the badge.

"require": {
        "php": "^7.1",
       "drupal/core": "^8 || ^9"
  },

It also looks like it may possible to get the badge by adding the 'core_version_requirement' key in the modules info.yml file, which, in turn, will add the version to the require section of composer.json. Example follows.

core_version_requirement: ^8 || ^9
malte.koelle’s picture

malte.koelle commented
Status: Needs work » Needs review
StatusFileSize
new prepare-the-module-for-d9-3109593-#3.patch1.69 KB

I have created a patch to remove the deprecated warnings in the FocalPointEffectsTest.
As far as I've seen it the 'core_version_requirement' key is already in the info.yml file.
I would appreciate any feedback.

skaught’s picture

skaught
Primary language English
commented

Crop API is also preparing..
#3121231: Declare Drupal 9 compatibility in crop_media_entity

bleen’s picture

bleen commented

Committed the patch in #3 to remove those extraneous deprecation messages ... also confirmed that `core_version_requirement: ^8 || ^9` is in the info.yml

bleen’s picture

bleen commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.