Problem/motivation
In the .install file, an update hook, numbered 8000, exists, which enables the readmehelp module.

However, there is no hook_install() implementation, which would be used to set the installed schema version.

any time a hook_update_N() is added to the module, this function needs to be updated to reflect the current version of the database schema.

The result is that any sites that have CKEditor Height enabled will see this 8000 update hook fire every time the database update process is initiated.

Proposed resolution
1. Add a hook_install() implementation that sets the schema version and enables the readmehelp module (if the maintainer really feels that's necessary; see discussion in #3107733: Dependency to readmehelp?

CommentFileSizeAuthor
#2 3108633-2.patch576 bytesmark_fullmer

Comments

mark_fullmer created an issue. See original summary.

mark_fullmer’s picture

Status: Active » Needs review
StatusFileSize
new576 bytes

The attached patch leaves the update hook that tries to enable readmehelp, but changes the update hook number from 8000 (which will never auto-increment, and therefore fire on every database update) to 8101.

geek-merlin’s picture

Status: Needs review » Fixed

Thanks for filing this, what a stupid thing that seems to work but shoots in us the knee. As we remove the dependency, we can remove that erroneous hook too. Commit follows.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.