Hello,

on my view I have a field(to be more exactly a "Content revision: Link to Content" field), which has a text for no results behavior. This text is not translatable as far as I could see. It does not appear at admin/structure/views/view/MY-VIEW/translate/en/edit.

CommentFileSizeAuthor
#24 drupal-views_no_results_translateable_11-3107212-24.patch1.08 KBliam morland
#24 drupal-views_no_results_translateable_10.4-3107212-24.patch1.08 KBliam morland
#22 drupal-views_no_results_translateable-3107212-22.patch1.08 KBliam morland
#19 d10-1-x--3107212-19.patch1.08 KBliam morland
#19 d9-5-x--3107212-19.patch1.08 KBliam morland
#19 d9-4-x--3107212-19.patch1.08 KBliam morland
#13 d9-4-x--3107212-13.patch1.09 KBrajab natshah
#13 d9-3-x--3107212-13.patch1.07 KBrajab natshah
#5 3107212-5.patch1.07 KBlendude
#5 interdiff-3107212-3-5.txt464 byteslendude
#4 Screenshot 2020-02-26 at 13.21.27.png32.44 KBlendude
#3 3107212-3.patch1.08 KBlendude

Issue fork drupal-3107212

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 3107212-views-no-results Comparechanges, plain diff MR !1954
    • 2 hidden branches
  • main Comparecompare
  • 11.x Comparecompare
About issue forks

Comments

dercheffe created an issue. See original summary.

Miras-Etrin’s picture

Miras-Etrin commented

same.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Active » Needs review
StatusFileSize
new 3107212-3.patch1.08 KB

This should do the trick.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
StatusFileSize
new Screenshot 2020-02-26 at 13.21.27.png32.44 KB

This shows that the field shows up in the translation interface with the patch in #3

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
StatusFileSize
new interdiff-3107212-3-5.txt464 bytes
new 3107212-5.patch1.07 KB

Hm ok it should be text really since the original input is multiline

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Youcanlearnit’s picture

Youcanlearnit commented

Thanks for this patch #5, works with my D 9.2.10 setup

Rajab Natshah opened merge request !1954

Rajab Natshah made their first commit to this issue’s fork.

rajab natshah’s picture

rajab natshah
he/him
commented
StatusFileSize
new d9-3-x--3107212-13.patch1.07 KB
new d9-4-x--3107212-13.patch1.09 KB

Updated the patch as MR for 9.4.x
and attached 2 patches for upgrading from Drupal 8 to Drupal 9
on the 9.3.x and 9.4.x branches.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue tags: +Needs tests

Might need a test for this

z.stolar’s picture

z.stolar commented

I confirm this patch works and doesn't generate any errors in the dblog.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

#13 seems to be having build issues

Also moving back to NW for tests.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs work » Needs review
StatusFileSize
new d9-4-x--3107212-19.patch1.08 KB
new d9-5-x--3107212-19.patch1.08 KB
new d10-1-x--3107212-19.patch1.08 KB

Rerolls

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Thank you for working on this!

Moving back to NW for the test cases.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
StatusFileSize
new drupal-views_no_results_translateable-3107212-22.patch1.08 KB

I have rebase the issue fork onto 11.x. The merge request needs to be updated so that it targets 11.x. The probably needs to be done by the owner of the merge request, @Rajab Natshah.

This patch is for Drupal 10.2.x.

erwangel’s picture

erwangel commented

Tested #22 on Drupal 10.3.6. Patch applied and everything looks okay.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
StatusFileSize
new drupal-views_no_results_translateable_10.4-3107212-24.patch1.08 KB
new drupal-views_no_results_translateable_11-3107212-24.patch1.08 KB

Re-rolled. Patches for 10.4.x and 11.x attached.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

yospyn’s picture

yospyn commented

Thanks for the 10.4 patch, confirming it also works on 10.6.

yospyn’s picture

yospyn commented

Had trouble with #24 for Drupal 11 after attempting upgrade to 11.3.3.

The D10 version is still working on 10.6.3 though.

neptune-dc made their first commit to this issue’s fork.

neptune-dc’s picture

neptune-dc commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

Left comments on the MR.

Summary also is incomplete.

yospyn’s picture

yospyn commented

Updated patch via #28 works well for me on 11.3.4.

oily changed the visibility of the branch main to hidden.

oily changed the visibility of the branch 11.x to hidden.

oily’s picture

oily commented

Aiming to write test coverage. But first, removed the unnecessary test identified in code review.