Closed (fixed)
Project:
Autofill
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
16 Jan 2020 at 14:24 UTC
Updated:
3 Aug 2020 at 14:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mtodor commentedComment #3
szeidler commentedThanks for your input.
You're right. The reason is, that we only had a single variable
var target_field_was_manipulated, that state if a target was manipulated. Actually this needs to be handled per target field.I changed the javascript to be able to do that. I adopted also your scenario in the tests.
Thanks for a review.
Comment #4
bernardm28 commentedDoes this allow autofill from two sources? For example if one wants to autofill from the Firstname and Lastname fields.
Comment #5
chr.fritschI checked the patch and found one small problem.
I have 4 fields: one, one_clone, two and two_clone.
one is mapped to one_clone and two to two_clone.
I type something in one_clone and then into one. No overwrite of one_clone, fine.
I type something into two and nothing is copied to two_clone. That should be because two_clone is still empty.
Comment #6
chr.fritschI extended the test and fixed the bug I found.
Comment #7
volkerk commentedI manually tested this using one source and multiple targets and also chaining multiple fields. Works as expected.
Comment #9
szeidler commentedI tested patch #6 as well. Thanks for spotting and fixing the bug. It looks alright for me now and got committed.