Nothing in the module *requires* the Search API Solr module. I wanted to implement my own spell check for database searching, but I don't want to enable all the Solr modules. This is just an API providing module so I think we don't need to match versions with Search API Solr either.

Comments

Dave Reid created an issue. See original summary.

the_g_bomb’s picture

Status: Active » Needs review
StatusFileSize
new1017 bytes

Not tested as yet, but in theory, this should remove the dependency

studgate’s picture

this patch works for me... don't understand the required solr dependency.

mkalkbrenner’s picture

Status: Needs review » Needs work

The problem is that no other Search API backend module except Search API Solr delivers results out of the box. So this dependency targets the end-user, not the developer.
If you contribute your "own" implementations and officially contribute them to Search API's database backend we could remove the dependency.
And I really would appreciate that!

mkalkbrenner’s picture

Alternatively a patch could be accepted that checks if the backend supports the spellcheck feature and turns off the functionality otherwise.
If I think twice, this is the better way compared to #4.
We do so in search_api_autocomplete:

if ($server->supportsFeature('search_api_autocomplete')) {
  ...
}
mkalkbrenner’s picture

Status: Needs work » Needs review
StatusFileSize
new4.42 KB

  • mkalkbrenner committed 2b15919 on 8.x-3.x
    Issue #3106736 by mkalkbrenner, the_g_bomb, Dave Reid, studgate: Drop...
mkalkbrenner’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.