It would be very convenient to add token support for the base_uri so this can be changed from the configuration interface without the need to deploy new yml files or alter settings.php.

CommentFileSizeAuthor
#5 base_uri_token_support-3105372-5.patch3.3 KBaronne
#2 base_uri_token_support-3105372-1.patch1.3 KBkurkuma

Comments

kurkuma created an issue. See original summary.

kurkuma’s picture

kurkuma commented
StatusFileSize
new base_uri_token_support-3105372-1.patch1.3 KB

Find patch attached to parse tokens in the base_uri.
If a string is defined insead of a token it will be used instead.

aronne’s picture

aronne commented
Status: Needs review » Needs work

Hi @kurkuma and thx for contributing with your patch.
Just few things:

  • avoid usage of \Drupal::token(). Use Dependency Injection please.
  • the if - else condition could be improved by keeping the $base_uri = $config['base_uri'] at the beginning of the method and then removing the else statement
aronne’s picture

aronne commented
Status: Needs work » Closed (duplicate)

Closing because deprecated by #3009623: How to add configuration values to service?

aronne’s picture

aronne commented
Assigned: Unassigned » aronne
Status: Closed (duplicate) » Fixed
StatusFileSize
new base_uri_token_support-3105372-5.patch3.3 KB

Hi,
I'm reopening this issue and uploading a proper patch which works with the last version of the module.

Regards.

  • aronne authored d9cd3d3c on 9.3.x 
    Issue #3105372 by kurkuma, aronne: Allow for configurable base_uri value
aronne’s picture

aronne commented
Title: Allow for configurable base_uri value » Allow using tokens as base_uri value

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.