FILE: disable_html5_validation/disable_html5_validation.module
-----------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
1 | ERROR | [x] Missing file doc comment
5 | ERROR | [x] Expected 1 blank line before function; 0 found
5 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
-----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#10 disable_html5_validation_issues-3105033-update.patch654 bytesrohitrajputsahab
#7 disable_html5_validation_issues-3105033.patch643 bytesrohitrajputsahab

Comments

rohit-drupal created an issue. See original summary.

sch4lly’s picture

sch4lly commented
Status: Needs work » Closed (won't fix)

I will fix this in the next release.

rohitrajputsahab’s picture

rohitrajputsahab commented

Please give me credit, You can give it from the comment section.

sch4lly’s picture

sch4lly commented

Credit for what?

rohitrajputsahab’s picture

rohitrajputsahab commented

FOR FOUND ERRORS

sch4lly’s picture

sch4lly commented

Feel free to provide a patch, I will happily commit it. You get credit then!

rohitrajputsahab’s picture

rohitrajputsahab commented
StatusFileSize
new disable_html5_validation_issues-3105033.patch643 bytes

@sch4lly Use this patch to solve your module errors.

rohitrajputsahab’s picture

rohitrajputsahab commented
Status: Closed (won't fix) » Needs review
sch4lly’s picture

sch4lly commented
Status: Needs review » Needs work

Thanks for the patch. The @file comment uses the wrong module name though.

rohitrajputsahab’s picture

rohitrajputsahab commented
StatusFileSize
new disable_html5_validation_issues-3105033-update.patch654 bytes

Oops, yes you are right. Please check the new one patch.

rohitrajputsahab’s picture

rohitrajputsahab commented
Status: Needs work » Needs review
andrewmacpherson’s picture

andrewmacpherson commented
Title: Errors Found » Coding standards errors Found

making the issue title clearer

andrewmacpherson’s picture

andrewmacpherson commented
Status: Needs review » Reviewed & tested by the community

The patch in #10...

  1. Applies cleanly
  2. Fixes all 4 errors. I ran phpcs --standard=Drupal,DrupalPractice before and after the patch.
  3. Corrects the module name in the @file docblock, per comment #9

sch4lly’s picture

sch4lly commented

Thanks! Commited to 8.x-1.1

sch4lly’s picture

sch4lly commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.