We can use \Drupal::messenger()->addMessage instead of drupal_set_message

CommentFileSizeAuthor
#4 ad_entity_cleanly.png102.89 KBguilhermevp
#2 ad_entity-3101208-2.patch5.7 KBpifagor

Comments

pifagor created an issue. See original summary.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Active » Needs review
StatusFileSize
new ad_entity-3101208-2.patch5.7 KB
mxh’s picture

mxh commented
Parent issue: » #3212314: Establish Drupal 9 compatibility
guilhermevp’s picture

guilhermevp commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new ad_entity_cleanly.png102.89 KB

Patch applies cleanly and works as intended. However, I believe a better patch would remove \Drupal calls from classes with Dependency Injection.

RTBC.1

  • shagel committed 2c754de on 8.x-1.x 
    Applyed patches #3109400 #3101208 #3182435

mxh credited shagel.

mxh’s picture

mxh commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.