Hello,

I've seen that the module still uses a few deprecated methods.
I replace a few but might have missed some thought i was worth sharing.

Kind regards
Andrew

CommentFileSizeAuthor
#11 interdiff-3100208-9-11.txt4.43 KBmanuel.adan
#11 email_confirmer-replace_deprecations-3100208-11.patch15.92 KBmanuel.adan
#9 email_confirmer-replace_deprecations-3100208-9.patch12.46 KBdaniel kulbe
#8 email_confirmer-replace_deprecations-3100208-8.patch12.08 KBdaniel kulbe
#6 interdiff-3100208-5-6.txt562 bytesmanuel.adan
#6 email_confirmer-replace_deprecations-3100208-6.patch10.55 KBmanuel.adan
#5 interdiff-3100208-2-5.txt1.2 KBmanuel.adan
#5 email_confirmer-replace_deprecations-3100208-5.patch10.55 KBmanuel.adan
#2 email_confirmer-replace_deprecations-3100208-2.patch10.43 KBandrewtur

Issue fork email_confirmer-3100208

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Andrew@Germany created an issue. See original summary.

andrewtur’s picture

andrewtur commented
StatusFileSize
new email_confirmer-replace_deprecations-3100208-2.patch10.43 KB
knyshuk.vova’s picture

knyshuk.vova commented
Status: Active » Needs review
knyshuk.vova’s picture

knyshuk.vova commented
Issue tags: +LutskGCW20

Tagging for Drupal Global Contribution Weekend

manuel.adan’s picture

manuel.adan
Location 🌌
commented
StatusFileSize
new email_confirmer-replace_deprecations-3100208-5.patch10.55 KB
new interdiff-3100208-2-5.txt1.2 KB

Some PHPDocs and one unused use statement.

manuel.adan’s picture

manuel.adan
Location 🌌
commented
StatusFileSize
new email_confirmer-replace_deprecations-3100208-6.patch10.55 KB
new interdiff-3100208-5-6.txt562 bytes

Fixes wrong property name replacement.

daniel kulbe’s picture

daniel kulbe
he/him
Primary language German
Location Berlin
commented

One thing I noticed, the entity type manager is always saved as property of the classes, but rarely used.
It would be more efficient to save the email_confirmer_confirmation storage as property and work directly with it, instead of instantiating it over and over again ...

daniel kulbe’s picture

daniel kulbe
he/him
Primary language German
Location Berlin
commented
StatusFileSize
new email_confirmer-replace_deprecations-3100208-8.patch12.08 KB

I removed a unused use statement in module file and replaced appearances of REQUEST_TIME.

daniel kulbe’s picture

daniel kulbe
he/him
Primary language German
Location Berlin
commented
StatusFileSize
new email_confirmer-replace_deprecations-3100208-9.patch12.46 KB

Found an other occurrence of REQUEST_TIME.

daniel kulbe’s picture

daniel kulbe
he/him
Primary language German
Location Berlin
commented
Status: Needs review » Needs work

Further deprecations:

  • Call to deprecated method substr() of class Drupal\Component\Utility\Unicode. Deprecated in drupal:8.6.0 and is removed from drupal:9.0.0. Use mb_substr() instead.
  • Call to deprecated function drupal_set_message(). Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
manuel.adan’s picture

manuel.adan
Location 🌌
commented
Title: Replace deprecations » Replace deprecations, Drupal 9 compatibility
Status: Needs work » Needs review
StatusFileSize
new email_confirmer-replace_deprecations-3100208-11.patch15.92 KB
new interdiff-3100208-9-11.txt4.43 KB
  • Some REQUEST_TIME remaining replacements
  • Uses this issue for the D9 compatibility task

  • manuel.adan committed 511a8e2 on 8.x-1.x 
    Issue #3100208 by manuel.adan, Daniel Kulbe, Andrew@Germany: Replace...
manuel.adan’s picture

manuel.adan
Location 🌌
commented
Status: Needs review » Fixed
Issue tags: -LutskGCW20

Committed, thanks. It seems that finally there were no activity from LutskGCW20.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.