drupal-check against better_search 8.x-1.x-dev (30 Nov 2019)

➜  d9readiness vendor/mglaman/drupal-check/drupal-check web/modules/contrib/better_search
 3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


 [OK] No errors

Upgrade status report against better_search 8.x-1.x-dev (30 Nov 2019)

Add core_version_requirement: ^8 || ^9 to better_search.info.yml to designate that the module is compatible with Drupal 9. See https://www.drupal.org/node/3070687.

CommentFileSizeAuthor
#7 3097784-5.patch352 bytesyogeshmpawar
#5 3097784-5.patch326 bytesyogeshmpawar
#3 drupal_9_deprecated_code_report-3097784-2.patch379 bytesgnanagowthaman sankar

Comments

yogeshmpawar created an issue. See original summary.

gnanagowthaman sankar’s picture

gnanagowthaman sankar commented

Hi @yogeshmpawar ,

Here by i attached the patch. Please let me know for any changes.

Thanks & Regards,
Gnanagowthaman sankar

gnanagowthaman sankar’s picture

gnanagowthaman sankar commented
Status: Active » Needs review
StatusFileSize
new drupal_9_deprecated_code_report-3097784-2.patch379 bytes

Patch

Thanks & Regards,
Gnanagowthaman sankar

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Issue tags: +Drupal 9 compatibility
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
StatusFileSize
new 3097784-5.patch326 bytes

Removing this patch

gnanagowthaman sankar’s picture

gnanagowthaman sankar commented

ok @yogeshmpawar

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
StatusFileSize
new 3097784-5.patch352 bytes

@Gnanagowthaman sankar - There is no need to remove core: from the *.info.yml file. Please refer - https://www.drupal.org/node/3070687 for more details.
I am attaching the patch for this fix.

  • yogeshmpawar committed fd0a253 on 8.x-1.x 
    Issue #3097784 by yogeshmpawar, Gnanagowthaman sankar: Drupal 9...
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Status: Needs review » Fixed

Committed & Pushed to 8.x-1.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.