Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#19 | interdiff-3097453-16-19.txt | 1.48 KB | JeroenT |
#19 | 3097453-19.patch | 149.33 KB | JeroenT |
#16 | interdiff-3097453-13-16.txt | 1.54 KB | JeroenT |
#16 | 3097453-16.patch | 150.44 KB | JeroenT |
#13 | 3097453-13-interdiff.txt | 1.04 KB | Berdir |
Comments
Comment #2
longwaveFirst pass at this; I probably missed some things, but there is also the deprecation testing code that we need to keep for future deprecations.
Comment #4
longwavePostponed on #3015812: Introduce new Theme extension object and properly deprecate REGIONS_VISIBLE and REGIONS_ALL
Comment #5
longwaveLet's try again with the REGIONS_* constants back in.
Comment #7
andypostIt should not be blocked on the deprecation of constants because @alexpott said it will be ready for work in 9.1
Comment #8
longwaveAlso needs #3015811: Properly deprecate DRUPAL_USER_TIMEZONE_* constants and #3075490: Move simpletest module to contrib.
This patch restores more constants, adds back the deprecated version of AssertPageCacheContextsAndTagsTrait still used by WebTestBase, and removes another test and some unused use statements.
Comment #9
BerdirThis overlaps with #3092090: Remove legacy Path Alias subsystem, I don't think the implementation of this actually gets removed here as that is in path_alias module. I'd suggest to remove it from this patch.
Comment #10
longwaveFixed #9.
Comment #11
BerdirReroll. Also removing core/modules/system/src/Plugin/views/field/BulkForm.php now that the update path is gone.
There are a few left-over deprecated things that we apparently can't remove yet, as they are still used (constants, test trait) or are actually testing the deprecation handling itself.
Comment #13
BerdirYay, so removing BulkForm works now too. Fixed the plugin test, the media_library test looks like a random fail.
Comment #14
Wim LeersIdeally we'd have a follow-up issue created that lists those. But … I don't think neither the existence of the follow-up issue nor the need for a follow-up issue should block this. Because
… goes a very substantial way towards getting to a point of having no more deprecated code in Drupal 9 core, and hence gets us closer to 9.0.0. This will help get the chart at https://dev.acquia.com/drupal9/deprecation_status/graphs a lot closer to zero.
(This patch removes 27 occurrences of
@deprecated
, or 8% of the remaining ones as of Monday January 20.)Reviewed the entire patch. This looks ready :) 🚢
Comment #15
Wim LeersD'oh, just noticed
in
\Drupal\Tests\views\Kernel\PluginInstanceTest
. We'll need to remove that too, since this patch is removing that class.Sorry, @Berdir :)
Comment #16
JeroenTPatch attached removes the deprecatedPlugins check as suggested in #15.
Comment #17
JeroenTComment #18
Wim LeersWoah, you were on that really fast, @JeroenT, thanks! 🙏
🤓 Nit: This comment has not yet been updated.D'oh, nope, we can't do most of what's in #16, no matter how tempting it is 😞 Because it ironically would itself introduce a BC break!
The BC break here is that contrib/custom modules may be subclassing
\Drupal\Tests\views\Kernel\PluginInstanceTest
and may be expanding thedeprecatedPlugins
class property and/or they may be calling::assertPluginInstances(FALSE)
. The #16 interdiff would break those modules, without that first having been deprecated.So, all of #16 needs to be reverted, and we just need the
deprecatedPlugins
class property to be set to the empty array.Comment #19
JeroenT🤦♂️Reverted #16 and replaced the
deprecatedPlugins
property with an empty array.Comment #20
Wim LeersPerfect, thanks!
Comment #21
alexpottNice!
Committed 46bd90d and pushed to 9.0.x. Thanks!
As far as I can see follow-ups exist for the things that are still deprecated.