I'm testing access_unpublished with 9.0.x dev right now, it's working for the most part, however the ajax service needs this fix:

see attachment.

Comments

joseph.olstad created an issue. See original summary.

joseph.olstad’s picture

entity.manager is deprecated and D9 removes deprecated apis

so the fix is to change it from entity.manager to entity_type.manager.

see patch.

joseph.olstad’s picture

Assigned: joseph.olstad » Unassigned
chr.fritsch’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new3.95 KB

Thanks for the patch. Here is another one with everything else I could found.

joseph.olstad’s picture

Ok looks like we need BOTH patches right?

chr.fritsch’s picture

We need only #4. it contains #2

chr.fritsch’s picture

Issue tags: +Drupal 9 compatibility
alexpott’s picture

  1. +++ b/access_unpublished.info.yml
    @@ -2,5 +2,5 @@ name: 'Access Unpublished'
    +core_version_requirement: ^8.7.7 || ^9
    
    +++ b/composer.json
    @@ -2,6 +2,9 @@
    +        "drupal/core": "^8.7.7 || ^9"
    

    How about ^8 || ^9? I don't think there are any changes here that require ^8.7.7

  2. +++ b/tests/src/Functional/AccessTest.php
    @@ -17,7 +17,15 @@ class AccessTest extends BrowserTestBase {
    +  /**
    +   * {@inheritdoc}
    +   */
    +  protected $defaultTheme = 'classy';
    
    +++ b/tests/src/Functional/ContentModerationAccessTest.php
    @@ -19,7 +19,19 @@ class ContentModerationAccessTest extends BrowserTestBase {
    +  /**
    +   * {@inheritdoc}
    +   */
    +  protected $defaultTheme = 'classy';
    
    +++ b/tests/src/FunctionalJavascript/AccessUnpublishedTest.php
    @@ -19,11 +19,14 @@ class AccessUnpublishedTest extends WebDriverTestBase {
    +  protected $defaultTheme = 'classy';
    

    I might be worth a follow-up to make these tests not depend on classy.

chr.fritsch’s picture

How about ^8 || ^9? I don't think there are any changes here that require ^8.7.7

Only 8.7.11 is still supported by drupal. So I don't mind requiring 8.7.7

alexpott’s picture

Status: Needs review » Reviewed & tested by the community

Fair enough.

chr.fritsch’s picture

Status: Reviewed & tested by the community » Fixed

Done

  • chr.fritsch committed 75e433f on 8.x-1.x
    Issue #3096984 by joseph.olstad, chr.fritsch, alexpott: Drupal 9...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.