ATM it seems that this module only support embedding of tracks and will not allow postcasts. This patch will fix this as well as support for other changes I have made to Video embed field to add support for GraphQL

Comments

gordon created an issue. See original summary.

gordon’s picture

StatusFileSize
new2.89 KB
gordon’s picture

Status: Active » Needs review
sleitner’s picture

StatusFileSize
new6.16 KB

@gordon thanks for the patch. I reworked the regex to match album, artist, playlist and show as well.

  • sleitner committed 3af997e on 8.x-1.x
    Issue #3091990 by gordon, sleitner: Update to support podcasts as well...
callinmullaney’s picture

StatusFileSize
new478 bytes

When reviewing the latest patch I kept running into this error on the frontend while testing spotify episodes and podcast embeds. Error: Call to undefined method Drupal\video_embed_spotify\Plugin\video_embed_field\Provider\Spotify::getEmbedUrl()...

I updated the patch with the new method and the embeds are working great for me now.

callinmullaney’s picture

StatusFileSize
new4.25 KB
sleitner’s picture

StatusFileSize
new1.8 KB

@callinmullaney you're right, the getEmbedUrl function is part of @gordon 's ProviderPluginBase implementation and ProviderPluginInterface (#3091986) which is not in the video_embed_field 8.x-2.x branch yet. I changed the code to adapt these changes.

  • sleitner committed 586cc39 on 8.x-1.x
    Revert "Issue #3091990 by callinmullaney, gordon, sleitner: Update to...
  • sleitner committed 8b9ad83 on 8.x-1.x
    Issue #3091990 by callinmullaney, gordon, sleitner: Update to support...
  • sleitner committed c2d3bfe on 8.x-1.x
    Issue #3091990 by callinmullaney, gordon, sleitner: Update to support...
  • sleitner committed fa48663 on 8.x-1.x
    Issue #3091990 by callinmullaney, gordon, sleitner: Update to support...
sleitner’s picture

Assigned: gordon » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.