Problem/Motivation

The migration to Layout Builder does not support static contexts. The Core Context modules provides support for non-required contexts, but static context values are not dealt with at all.

Proposed resolution

Migrate static contexts into the correct destinations:

  • Required contexts need to be passed in the block configuration of each component.
  • Optional contexts need to be attached to the entity view display, or whatever is carrying the section list.

Remaining tasks

Do it and add tests.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

CommentFileSizeAuthor
#12 3091783-12.patch21.94 KBphenaproxima
#11 3091783-11.patch17.95 KBphenaproxima
#10 3091783-10.patch14.08 KBphenaproxima
#9 3091783-9.patch9.53 KBphenaproxima
#7 3091783-7.patch9.88 KBphenaproxima
#6 3091783-6.patch9.53 KBphenaproxima
#5 3091783-5.patch9.81 KBphenaproxima
#4 3091783-4.patch7.04 KBphenaproxima
#3 3091783-3.patch6.31 KBphenaproxima
#2 3091783-2.patch6.3 KBphenaproxima

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Needs review
Issue tags: +Needs tests
StatusFileSize
new 3091783-2.patch6.3 KB

Will it fail? Will it pass? Let's find out.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3091783-3.patch6.31 KB

This should fail fewer tests.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3091783-4.patch7.04 KB

And this should fix the final failure.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3091783-5.patch9.81 KB

Now with basic low-level test coverage. Still needs higher-level functional coverage, though.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3091783-6.patch9.53 KB

Removing a bit of incorrect detritus.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3091783-7.patch9.88 KB

Okay, apparently now we have a forced dependency on core_context. Joy!

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Postponed

Blocked on #3091831: Add Core Context as a dependency.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Postponed » Needs review
StatusFileSize
new 3091783-9.patch9.53 KB

Okay, committed that. Let's see if this flies.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3091783-10.patch14.08 KB

Added high-level functional test coverage for nodes.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3091783-11.patch17.95 KB

...and for users.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Issue tags: -Needs tests
StatusFileSize
new 3091783-12.patch21.94 KB

...and taxonomy terms.

  • phenaproxima committed 49efe77 on 8.x-5.x 
    Issue #3091783 by phenaproxima: Support migrating static contexts
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.