7/7 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ --------------------------------------------------------------------------
Line reference_value_pair.views.inc
------ --------------------------------------------------------------------------
26 Call to deprecated method entityManager() of class Drupal:
in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
Use \Drupal::entityTypeManager() instead in most cases. If the needed
method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the
deprecated \Drupal\Core\Entity\EntityManager to find the
correct interface or service.
------ --------------------------------------------------------------------------

------ --------------------------------------------------------------------------
Line src/Plugin/Field/FieldFormatter/ReferenceValueFormatterBase.php
------ --------------------------------------------------------------------------
118 Call to deprecated method entityManager() of class Drupal:
in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
Use \Drupal::entityTypeManager() instead in most cases. If the needed
method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the
deprecated \Drupal\Core\Entity\EntityManager to find the
correct interface or service.
------ --------------------------------------------------------------------------

------ --------------------------------------------------------------------------
Line src/Plugin/Field/FieldType/ReferenceValuePair.php
------ --------------------------------------------------------------------------
69 Call to deprecated method entityManager() of class Drupal:
in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
Use \Drupal::entityTypeManager() instead in most cases. If the needed
method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the
deprecated \Drupal\Core\Entity\EntityManager to find the
correct interface or service.
73 Call to deprecated method entityManager() of class Drupal:
in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
Use \Drupal::entityTypeManager() instead in most cases. If the needed
method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the
deprecated \Drupal\Core\Entity\EntityManager to find the
correct interface or service.
111 Call to deprecated method entityManager() of class Drupal:
in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
Use \Drupal::entityTypeManager() instead in most cases. If the needed
method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the
deprecated \Drupal\Core\Entity\EntityManager to find the
correct interface or service.
209 Call to deprecated method entityManager() of class Drupal:
in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
Use \Drupal::entityTypeManager() instead in most cases. If the needed
method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the
deprecated \Drupal\Core\Entity\EntityManager to find the
correct interface or service.
362 Call to deprecated method entityManager() of class Drupal:
in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
Use \Drupal::entityTypeManager() instead in most cases. If the needed
method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the
deprecated \Drupal\Core\Entity\EntityManager to find the
correct interface or service.
369 Call to deprecated method entityManager() of class Drupal:
in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
Use \Drupal::entityTypeManager() instead in most cases. If the needed
method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the
deprecated \Drupal\Core\Entity\EntityManager to find the
correct interface or service.
399 Call to deprecated method entityManager() of class Drupal:
in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
Use \Drupal::entityTypeManager() instead in most cases. If the needed
method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the
deprecated \Drupal\Core\Entity\EntityManager to find the
correct interface or service.
409 Call to deprecated method entityManager() of class Drupal:
in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
Use \Drupal::entityTypeManager() instead in most cases. If the needed
method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the
deprecated \Drupal\Core\Entity\EntityManager to find the
correct interface or service.
501 Call to deprecated method entityManager() of class Drupal:
in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
Use \Drupal::entityTypeManager() instead in most cases. If the needed
method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the
deprecated \Drupal\Core\Entity\EntityManager to find the
correct interface or service.
------ --------------------------------------------------------------------------

------ ---------------------------------------------------------------------------
Line src/Plugin/Field/FieldWidget/ReferenceValueAutocompleteWidget.php
------ ---------------------------------------------------------------------------
189 Call to deprecated function entity_get_bundles():
in Drupal 8.x-dev and will be removed before Drupal 9.0.0. Use
\Drupal\Core\Entity\EntityTypeBundleInfoInterface::getBundleInfo() for a
single bundle, or
\Drupal\Core\Entity\EntityTypeBundleInfoInterface::getAllBundleInfo() for
all bundles.
------ ---------------------------------------------------------------------------

[ERROR] Found 12 errors

CommentFileSizeAuthor
#4 reference_value_pair-drupal9-3090670-4.patch39.47 KBamatzies
#2 reference_value_pair-3090670-2.patch9.82 KBrudranil29

Comments

joy29 created an issue. See original summary.

rudranil29’s picture

rudranil29 commented
StatusFileSize
new reference_value_pair-3090670-2.patch9.82 KB
rudranil29’s picture

rudranil29 commented
Assigned: rudranil29 » Unassigned
Status: Active » Needs review
amatzies’s picture

amatzies commented
StatusFileSize
new reference_value_pair-drupal9-3090670-4.patch39.47 KB

I'm getting an error after applying patch #2.
Call to undefined method Drupal\\Core\\Entity\\EntityTypeManager::getBaseFieldDefinitions()

My patch covers deprecation issues as well as dependency injection issues reported by drupal_check. I have also fixed coding standard issues by running code sniffer. If you want to omit these changes, I can certainly create another patch.

I have tested manually in Drupal 8.9.10 and 9.0.9. It works for me. A code review and further tests are appreciated.

kiseleva.t’s picture

kiseleva.t commented
Related issues: +#3148594: Automated Drupal 9 compatibility fixes

I've included #4 patch fixes into MR https://git.drupalcode.org/project/reference_value_pair/-/merge_requests... from task #3148594: Automated Drupal 9 compatibility fixes

coaston’s picture

coaston commented

kiselev.t - thank you, your version works fine with no issue. Do you think it would be possible to add select list option so I can use it instead of text area ?

First field I need to refefence user, and the second for role select, but need select list widget if possible.

  • jjcarrion committed dfc2a34 on 8.x-2.x authored by kiseleva.t 
    Issue #3090670 by joy29, amatzies, kiseleva.t: Drupal 9 code Report and...
jjcarrion’s picture

jjcarrion
Primary language Spanish
Location Spain
commented
Status: Needs review » Fixed

Merged the MR from #3090670 adding credits from this issue as well. I'm not really sure if they end up in the right place, sorry for that if I missed something :(

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.