I'm wondering if the directory https://git.drupalcode.org/project/tocbot/tree/7.x-1.x/.vscodewith the file settings.json should be part of the module repository. As far as I know, the goal of the file is to share Visual Studio related settings within a team, and I guess it makes sense to ignore it for the Git repository.

Comments

Olafski created an issue. See original summary.

nicholass’s picture

nicholass
Primary language English
Location FL
commented

@Olafski yes the module does not use it in anyway, a `.vscode` is a directory to keep editing consistent between developers. As this is my first module, I don't really know if it should be excluded I will have research and find any advice. Not sure what the Drupal world considers best practice on this.

  • NicholasS committed bc19a8b on 7.x-1.x 
    Issue #3088628: Clarify if the .vscode directory is necessary
nicholass’s picture

nicholass
Primary language English
Location FL
commented

After review a few other Drupal projects, I will remove these project setting/configuration files. Thanks for bringing this up!

nicholass’s picture

nicholass
Primary language English
Location FL
commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.