Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
See https://www.drupal.org/pift-ci-job/1436032
One of the initial test failures since 9.0.x has been branched.
#slow.Drupal\Tests\system\Functional\Update\UpdatePathTestBaseFilledTest
✗
Drupal\Tests\system\Functional\Update\UpdatePathTestBaseFilledTest
fail: [Other] Line 0 of sites/default/files/simpletest/phpunit-3.xml:
PHPunit Test failed to complete; Error: PHPUnit 6.5.14 by Sebastian Bergmann and contributors.
Testing Drupal\Tests\system\Functional\Update\UpdatePathTestBaseFilledTest
..F... 6 / 6 (100%)
Time: 8.06 minutes, Memory: 4.00MB
There was 1 failure:
1) Drupal\Tests\system\Functional\Update\UpdatePathTestBaseFilledTest::testUpdateHookN
Failed asserting that 8000 matches expected 8001.
/var/www/html/core/tests/Drupal/TestTools/PhpUnitCompatibility/PhpUnit6/TestCompatibilityTrait.php:51
/var/www/html/core/tests/Drupal/KernelTests/AssertLegacyTrait.php:37
/var/www/html/core/tests/Drupal/FunctionalTests/Update/UpdatePathTestBaseTest.php:103
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#10 | 3087991.patch | 658 bytes | catch |
Comments
Comment #2
mikelutzComment #3
jibran#3087644: Remove Drupal 8 updates up to and including 88** is battling with this one as well. I have added new D9 DB dump over there which is taken after adding
hook_update_last_removed
so every updated module has a different version now.Comment #4
Wim Leers@jibran Does that mean this should be blocked on #3087644: Remove Drupal 8 updates up to and including 88**? Or is this a duplicate? Or is there a logical subset that we can commit here to
9.0.x
to unbreak D9 automated testing?Comment #5
jibranThe test is failing independently to #3087644: Remove Drupal 8 updates up to and including 88**, I think fixing it here makes sense. DB dump updates can happen over there but the test should be fixed here first.
Comment #6
Wim LeersI looked at this for 10 minutes and had no idea where to start! 🤓😊
It sounds like you understand this much better. Could you roll a patch for this maybe? 😇
Comment #7
jibranOn it!
Comment #8
jibranOn second thought let fix it over in #3087644: Remove Drupal 8 updates up to and including 88**. Schema version is outdated as is when D9 installed
hook_update_last_removed
fixes that over there.Comment #9
BerdirI'm not sure we should close this just yet, I'd like to understand it better first.
@alexpott and @catch also had a discussion on slack today on what exactly the expected behavior is, which update functions should run and what shouldn't, also in regards to contrib modules.
If you're an 8.x-1.x module that is compatible with 8.8+ and 9.0+, how should you number these things? There is no right moment to switch to 900x.
Comment #10
catchThis should fix it, patch is self-explanatory.
(by 'fix it' I mean bring 6 fails down to 5, we have some unrelated ones in HEAD too)
Comment #11
jibranVerified locally, passes just fine. Also fixed fails in #3087644: Remove Drupal 8 updates up to and including 88**.
Comment #12
alexpottI was wondering if we could change this to
'*'
originally I thought "I guess not as the point is to test the core semver value" but I'm not so sure looking at the test code.Comment #14
jibranWe are down two fails so restoring RTBC.
Comment #15
alexpottSo let's do this for now and decide on #12 in a follow-up. Created #3088134: Major version dependent tests mean lots of work to get a new major branch started
Committed 3bd108b and pushed to 9.0.x. Thanks!