Problem/Motivation

\Drupal\extra_field\Plugin\ExtraFieldDisplayFormattedBase allows using the field template for outputting extra field elements. However, any cache dependencies added in viewElements are not applied to the field's output.

Proposed resolution

Apply cache dependencies set in viewElements to the formatted field output.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 3087346-2.patch6.24 KBidebr
#2 3087346-2-test-only.patch5.64 KBidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new 3087346-2-test-only.patch5.64 KB
new 3087346-2.patch6.24 KB

Attached patch implements the following changes:

  1. Applies cache dependencies set in viewElements() to the formatted field output.
  2. Adds test coverage for the above change.
sutharsan’s picture

sutharsan commented
Status: Needs review » Fixed

Good catch!

  • Sutharsan committed 8ffb22d on 8.x-1.x authored by idebr 
    Issue #3087346 by idebr: Apply cache dependencies set in viewElements to...

  • Sutharsan committed 8ffb22d on 8.x-2.x authored by idebr 
    Issue #3087346 by idebr: Apply cache dependencies set in viewElements to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.