(1.) Update README.md to follow best practices (headings need to be uppercase) https://www.drupal.org/node/2181737.

  • The INSTALLATION section is missing.

(2.) Issues related to Drupal coding standards):

FILE: ...or/drupal/pareviewsh/pareview_temp/paypal_subscriptions.services.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 5 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../src/Plugin/Commerce/PaymentGateway/ExpressCheckoutSubscriptions.php
--------------------------------------------------------------------------
FOUND 20 ERRORS AND 1 WARNING AFFECTING 16 LINES
--------------------------------------------------------------------------
  45 | ERROR   | [x] Data types in @return tags need to be fully
     |         |     namespaced
  46 | ERROR   | [ ] Missing @var tag in member variable comment
  78 | ERROR   | [x] Data types in @param tags need to be fully
     |         |     namespaced
 101 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: )
 139 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 139 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 140 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 140 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 141 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 141 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 142 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 142 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 143 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 143 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 158 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     5
 182 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     5
 183 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     5
 184 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     5
 185 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     5
 188 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 189 | ERROR   | [x] Expected 1 space after "=>"; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 20 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
CommentFileSizeAuthor
#4 3084852-4.patch4.92 KBvuil
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ilchovuchkov created an issue. See original summary.

vuil’s picture

Issue summary: View changes
vuil’s picture

Title: Covering for Security Advisory Shield » Improve Drupal coding standards
Issue summary: View changes
vuil’s picture

Status: Active » Needs review
FileSize
4.92 KB

Add a patch for.

vuil’s picture

Status: Needs review » Patch (to be ported)

Ready to be committed.

  • ilchovuchkov committed c3dd0f9 on 8.x-1.x
    Issue #3084852 by ilchovuchkov: Apply Drupal coding standards.
    
vuil’s picture

Status: Patch (to be ported) » Fixed

The patch is committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.