Problem/Motivation

The module tracks links but it will be useful to track images added with CKEditor Image plugin.

Proposed resolution

Add a 'CKEditor Image' plugin to be able to track images (files) added with CKEditor Image:

$xpath->query('//img[@data-entity-type and @data-entity-uuid]')

User interface changes

New 'CKEditor Image' option under the 'Enabled Tracking Plugins' on the 'Entity Usage Settings' config page.

Data model changes

New configuration key 'ckeditor_image' for 'track_enabled_plugins'.

CommentFileSizeAuthor
#2 tracking-ckeditor-images-3083970-2.patch1.65 KBszato

Issue fork entity_usage-3083970

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

szato created an issue. See original summary.

szato’s picture

szato commented
Assigned: szato » Unassigned
Status: Active » Needs review
StatusFileSize
new tracking-ckeditor-images-3083970-2.patch1.65 KB

Patch implements 'ckeditor_image' tracking plugin.

claudiu.cristea made their first commit to this issue’s fork.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Assigned: Unassigned » claudiu.cristea
Status: Needs review » Needs work
Issue tags: +Needs tests

Adding tests

claudiu.cristea opened merge request !43

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Assigned: claudiu.cristea » Unassigned
Status: Needs work » Needs review
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Priority: Normal » Major
Issue tags: -Needs tests
  • Bumping to "Major" as images uploaded/embedded with CKEditor are a core feature.
  • Added tests. Untagging
  • The MR is also fixing the module to be installed with D10 by fixing the dynamic_entity_reference constraint.
  • Fixed all functional/javascript tests to run successfully on D10 by changing the theme. Classy theme has been removed from D10.

marcoscano made their first commit to this issue’s fork.

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
commented
Status: Needs review » Fixed

Thanks for contributing! Just merged, and will be tagging a new release soon. 👍

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.