Currently class TintEmbedBlockDerivative is accessing configurations using \Drupal::config('tint.settings') but as per drupal standards we should inject service inside the class.

CommentFileSizeAuthor
#9 dependency_injection-3081981-2.patch2.44 KBRangaswini
#2 dependency_injection-3081981.patch1.69 KBRangaswini

Comments

Rangaswini created an issue. See original summary.

Rangaswini’s picture

Rangaswini commented
StatusFileSize
new dependency_injection-3081981.patch1.69 KB

Attached patch to add dependency injection inside the class.

Rangaswini’s picture

Rangaswini commented
Status: Active » Needs review
ambuj_gupta’s picture

ambuj_gupta commented
Assigned: Rangaswini » ambuj_gupta
ambuj_gupta’s picture

ambuj_gupta commented

Tested and verified the module by adding the patch created by @rangaswini. It looks good to me.

ambuj_gupta’s picture

ambuj_gupta commented
Assigned: ambuj_gupta » Unassigned
Status: Needs review » Reviewed & tested by the community
pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Status: Reviewed & tested by the community » Needs work

Currently class TintEmbedBlockDerivative is accessing configurations using \Drupal::config('tint.settings') but as per drupal standards we should inject service inside the class.

Rangaswini’s picture

Rangaswini commented
Assigned: Unassigned » Rangaswini
Rangaswini’s picture

Rangaswini commented
Status: Needs work » Needs review
StatusFileSize
new dependency_injection-3081981-2.patch2.44 KB
Rangaswini’s picture

Rangaswini commented
Assigned: Rangaswini » Unassigned
pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented

@Rangaswini patch LGTM.

pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Status: Needs review » Reviewed & tested by the community
sonvir249’s picture

sonvir249 commented
Version: 8.x-1.0-alpha1 » 8.x-1.0-alpha2

Committing changes into 8.x-1.0-alpha2.

sonvir249’s picture

sonvir249 commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.