From @bojanz on slack:

The payment method add/edit form is broken on the user pages for 2.14, for any onsite gateway that uses jquery's form.submit, because that doesn't set the triggering element name.

see the 3-line fix in https://www.drupal.org/project/commerce_authnet/issues/3069640

This issue is just a reminder to check if the problem exists, and I added the meta issue in related issues to track all onsite payment gateways.

CommentFileSizeAuthor
#3 3078425-3.patch3.51 KBmglaman

Comments

thenchev created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Title: Payment method on add/edit form » Support changes for Commerce 2.14

Addressbook also breaks Square because we have to pass a postal code. This isn't available when re-using addresses.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review
StatusFileSize
new 3078425-3.patch3.51 KB

Here is an initial patch, which fixes the form. However, it feels pretty rough with how we fetch the postal code.

  • mglaman committed 6daa9e7 on 8.x-1.x 
    Issue #3078425 by mglaman: Support changes for Commerce 2.14
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

luongosb’s picture

luongosb commented

The typeof check for the customerPostalCode is returning as a string for me and the error for "Postal Code is not valid" is triggered for users who are not using a billing profile. Would it be better to check if the field is empty instead of typeof so it can fall through to using the value from the postal code field?

if (drupalSettings.commerceSquare.customerPostalCode.length > 0)