Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.A colleague of mine - @ricksta (https://www.drupal.org/u/ricksta) - pointed out that when creating a "Custom block" via Layout Builder, the title confusingly reads "Add a new Inline block", which of course is the original name for what are now considered "Custom blocks", at least in the UI sense.
Steps to recreate:
- Install standard profile
- Add at least one additional custom block type besides the "Basic block"
- Enable Layout Builder
- Enable Layout Builder for Article Content type
- Go to edit layout
- Click "Add block"
- Click the "Create custom block" button
- The title of the tray reads 'Add a new Inline Block'
It appears to us we should have consistency here, in that the user has clicked "Create custom block", and the title reads "Add a new custom block"
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | after.png | 45.88 KB | swatichouhan012 |
| #7 | before.png | 45.75 KB | swatichouhan012 |
| #2 | 3072744-2.drupal.Add-a-new-inline-block-title-on-settings-tray-doesnt-match-Custom-block.patch | 689 bytes | twfahey |
Comments
Comment #2
twfahey CreditAttribution: twfahey as a volunteer and at University of Texas at Austin commentedComment #3
twfahey CreditAttribution: twfahey as a volunteer and at University of Texas at Austin commentedComment #4
tim.plunkettNote #3069446: Layout builder's "Add Block" sidebar menu UX improvements introduces more usage of the term "inline"
Comment #6
tim.plunkettI think this is still relevant, but I'm not 100% sure. Can we get some screenshots of the patch on latest Drupal?
Comment #7
swatichouhan012 CreditAttribution: swatichouhan012 at Valuebound for Valuebound commented@tim.plunkett i tested on 8.9.x-dev patch working as expected. I am attaching screenshot here kindly review.
Comment #8
tim.plunkettThanks!
Since the link you click to get to that screen is labeled "Create custom block", this change still makes sense.
Comment #10
Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 for Drupal India Association commentedFailure test case is unrelated to #2 patch, moving back to RTBC.
Comment #11
alexpottCommitted and pushed 2957b44ca6 to 9.0.x and 040a6e7fc6 to 8.9.x. Thanks!