Per the Module documentation guidelines, a module should Provide help text in the Drupal UI. This module is missing an implementation of hook_help().
Documentation:
https://www.drupal.org/docs/develop/documenting-your-project/module-docu...
https://www.drupal.org/node/632280
Patch to follow, thanks!

CommentFileSizeAuthor
#4 interdiff_2-4.txt1.49 KBzrpnr
#4 jquery_ui_controlgroup-hook_help-3071217-4.patch1.25 KBzrpnr
#3 Screenshot from 2019-08-01 14-41-57.png58.18 KBWilltg
#2 jquery_ui_controlgroup-hook_help-3071217-2.patch1.11 KBalonaoneill

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

alonaoneill commented
Assigned: alonaoneill » Unassigned
Status: Active » Needs review
StatusFileSize
new jquery_ui_controlgroup-hook_help-3071217-2.patch1.11 KB
Willtg’s picture

Willtg commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot from 2019-08-01 14-41-57.png58.18 KB

Code looks good, patch tested with STM and it worked well. Adding a screenshot below for confirmation.
Marking RTBC
Thank you for working on the module!

zrpnr’s picture

zrpnr
he/him
Primary language English
Location UTC-7
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new jquery_ui_controlgroup-hook_help-3071217-4.patch1.25 KB
new interdiff_2-4.txt1.49 KB

I just added the link to the change record and made small changes to line endings and to remove whitespace.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs review » Reviewed & tested by the community

Reviewed the changes in #4, this is RTBC.

  • zrpnr committed eb83236 on 8.x-1.x authored by alonaoneill 
    Issue #3071217 by zrpnr, alonaoneill, Willtg, bnjmnm: Hook Help is...
zrpnr’s picture

zrpnr
he/him
Primary language English
Location UTC-7
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.