Per the Module documentation guidelines, a module should Provide help text in the Drupal UI. This module is missing an implementation of hook_help().
Documentation:
https://www.drupal.org/docs/develop/documenting-your-project/module-docu...
https://www.drupal.org/node/632280
Patch to follow, thanks!

CommentFileSizeAuthor
#5 jquery_ui_selectmenu-hook_help-3071210-5.patch1.26 KBbnjmnm
#5 interdiff_2-5.txt1.5 KBbnjmnm
#3 Screenshot from 2019-08-02 10-12-55.png58.15 KBWilltg
#2 jquery_ui_selectmenu-hook_help-3071210-2.patch1.1 KBalonaoneill

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

alonaoneill commented
Assigned: alonaoneill » Unassigned
Status: Active » Needs review
StatusFileSize
new jquery_ui_selectmenu-hook_help-3071210-2.patch1.1 KB
Willtg’s picture

Willtg commented
StatusFileSize
new Screenshot from 2019-08-02 10-12-55.png58.15 KB

Code looks good, patch tested with STM and it worked well. Adding a screenshot below for confirmation.
Marking RTBC
Thank you for working on the module!

Willtg’s picture

Willtg commented
Status: Needs review » Reviewed & tested by the community
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new interdiff_2-5.txt1.5 KB
new jquery_ui_selectmenu-hook_help-3071210-5.patch1.26 KB

Added change record link and addressed a few tiny nits.

zrpnr’s picture

zrpnr
he/him
Primary language English
Location UTC-7
commented
Status: Needs review » Reviewed & tested by the community

Thanks for updating this #5, marking RTBC

  • zrpnr committed 4db4e8e on 8.x-1.x authored by alonaoneill 
    Issue #3071210 by bnjmnm, alonaoneill, Willtg, zrpnr: Hook Help is...
zrpnr’s picture

zrpnr
he/him
Primary language English
Location UTC-7
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.