Per the Module documentation guidelines, a module should Provide help text in the Drupal UI. This module is missing an implementation of hook_help().
Documentation:
https://www.drupal.org/docs/develop/documenting-your-project/module-docu...
https://www.drupal.org/node/632280
Patch to follow, thanks!

CommentFileSizeAuthor
#4 jquery_ui_spinner-hook_help-3071208-4.patch1.21 KBbnjmnm
#4 interdiff_2-4.txt1.43 KBbnjmnm
#3 Screenshot from 2019-08-02 10-35-22.png20.34 KBWilltg
#2 jquery_ui_spinner-hook_help-3071208-2.patch1.06 KBalonaoneill

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

alonaoneill commented
Assigned: alonaoneill » Unassigned
Status: Active » Needs review
StatusFileSize
new jquery_ui_spinner-hook_help-3071208-2.patch1.06 KB
Willtg’s picture

Willtg commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot from 2019-08-02 10-35-22.png20.34 KB

Code looks good, patch tested with STM and it worked well. Adding a screenshot below for confirmation.
Marking RTBC
Thank you for working on the module!

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new interdiff_2-4.txt1.43 KB
new jquery_ui_spinner-hook_help-3071208-4.patch1.21 KB

Added change record and addressed a few tiny nits.

zrpnr’s picture

zrpnr
he/him
Primary language English
Location UTC-7
commented
Status: Needs review » Reviewed & tested by the community

The formatting fixes and change record link in #4 look good, marking RTBC

  • bnjmnm authored 2066ef6 on 8.x-1.x 
    Issue #3071208 by bnjmnm, alonaoneill, Willtg, zrpnr: Hook Help is...
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.