Tests are currently failing, so let's fix that. :)

CommentFileSizeAuthor
#2 3069066-2.patch2.83 KBphenaproxima

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3069066-2.patch2.83 KB

Let's try this on for size. If it passes (and it should), I'll commit it.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Needs review
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented

I noticed test were failing earlier today. This was due to the recent merging of two commits, with the latter having been applied without being updated against 8.x-1.x.

I believe the failing test is due to , and the fix is evidenced in the change on https://www.drupal.org/project/layout_builder_styles/issues/3068722

-    $this->drupalGet('admin/structure/layout_builder_style/config');
+    $this->drupalGet('admin/config/content/layout_builder_style/config')
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

Yup, I had the same thing. The $block_node->toUrl() changes are just for brevity.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Needs review » Reviewed & tested by the community

In other words, the commit that was out of date was b55b70

  • phenaproxima committed 3ebd528 on 8.x-1.x 
    Issue #3069066 by phenaproxima, mark_fullmer: Fix tests
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.