The following error occurs:

( ! ) Fatal error: Uncaught TypeError: Argument 1 passed to Drupal\Core\Cache\CacheableMetadata::createFromRenderArray() must be of the type array, null given, called in /web/modules/contrib/block_field/src/Plugin/Field/FieldFormatter/BlockFieldLabelFormatter.php on line 40 and defined in /web/core/lib/Drupal/Core/Cache/CacheableMetadata.php on line 149

In BlockFieldLabelFormatter its stated:

CacheableMetadata::createFromRenderArray($elements[$delta]['content'])

But the element's render array is:

      $elements[$delta] = [
        '#markup' => $block_instance->label(),
      ];

This merge statement looks to be a mistake.

CommentFileSizeAuthor
#15 interdiff_9-15.txt761 bytestim-diels
#15 3068281-15-8.9.patch1.77 KBtim-diels
#9 interdiff_7_9-8.7.txt626 bytesieguskiza
#9 3068281-9-8.7.patch1.71 KBieguskiza
#7 intediff_2_7.txt1015 bytesieguskiza
#7 intediff_2_7-8.7.txt1.04 KBieguskiza
#7 intediff_2_7-test-only.txt1015 bytesieguskiza
#7 3068281-7.patch1.75 KBieguskiza
#7 3068281-7-8.7.patch1.71 KBieguskiza
#7 3068281-7-test-only.patch1.12 KBieguskiza
#3 3068281-3-8.7.patch1.7 KBieguskiza
#2 3068281-2.patch1.74 KBieguskiza
#2 3068281-2-test-only.patch1.12 KBieguskiza
block_field--label-merge-cacheable.patch639 bytesalmunnings
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

icondigital created an issue. See original summary.

ieguskiza’s picture

ieguskiza CreditAttribution: ieguskiza at European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
3068281-2-test-only.patch1.12 KB
3068281-2.patch1.74 KB

Hi, I added some tests to verify the issue. I attach a patch with only the test so it fails an another with the solution.

ieguskiza’s picture

ieguskiza CreditAttribution: ieguskiza at European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
3068281-3-8.7.patch1.7 KB

I noticed that my first proposal has a hard dependency on versions of Drupal higher than 8.8. I attach another patch that is compatible with previous releases since I'm not sure what the appropriate approach is here.

Chewie’s picture

Chewie CreditAttribution: Chewie at Petend for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Active » Needs review

Patch looks good for me.

sardara’s picture

sardara CreditAttribution: sardara at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented 
  1. +++ b/tests/src/Functional/BlockFieldTest.php
@@ -156,6 +156,19 @@ class BlockFieldTest extends BrowserTestBase {
+    // Use the Block Field Label formatter for the block_field_test display.

    Isn't "block_field_test" the bundle name? 

  2. +++ b/tests/src/Functional/BlockFieldTest.php
@@ -156,6 +156,19 @@ class BlockFieldTest extends BrowserTestBase {
+

    Let's put just a single empty line.

For the rest it looks good!

sardara’s picture

sardara CreditAttribution: sardara at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs review » Needs work
ieguskiza’s picture

ieguskiza CreditAttribution: ieguskiza at European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
3068281-7-test-only.patch1.12 KB
3068281-7-8.7.patch1.71 KB
3068281-7.patch1.75 KB
intediff_2_7-test-only.txt1015 bytes
intediff_2_7-8.7.txt1.04 KB
intediff_2_7.txt1015 bytes

Hi @sardara, here are the patches with all the changes you proposed. I also added an interdiff for all of them.

ieguskiza’s picture

ieguskiza CreditAttribution: ieguskiza at European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs work » Needs review
ieguskiza’s picture

ieguskiza CreditAttribution: ieguskiza at European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
3068281-9-8.7.patch1.71 KB
interdiff_7_9-8.7.txt626 bytes

It was brought to my attention that I left some spaces on the 8.7 compatible patch. I upload here another version without the spaces.

sardara’s picture

sardara CreditAttribution: sardara at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs review » Reviewed & tested by the community

Looks good! Moving to RTBC.

mpp’s picture

mpp CreditAttribution: mpp at AmeXio for District09 commented
Priority: Major » Critical

This is causing a fatal error without a workaround, setting to critical.

RTBC++

mpp’s picture

mpp CreditAttribution: mpp at AmeXio for District09 commented
Issue summary: View changes

Adding the complete error message for people to find this issue more easily.

( ! ) Fatal error: Uncaught TypeError: Argument 1 passed to Drupal\Core\Cache\CacheableMetadata::createFromRenderArray() must be of the type array, null given, called in /web/modules/contrib/block_field/src/Plugin/Field/FieldFormatter/BlockFieldLabelFormatter.php on line 40 and defined in /web/core/lib/Drupal/Core/Cache/CacheableMetadata.php on line 149
tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
CreditAttribution: tim-diels at Calibrate commented
Status: Reviewed & tested by the community » Needs work 
  1. +++ b/tests/src/Functional/BlockFieldTest.php
@@ -156,6 +156,18 @@ class BlockFieldTest extends BrowserTestBase {
+    // Use the Block Field Label formatter for the field_block_field_test display.

    phpcs: Line exceeds 80 characters; contains 82 characters 

  2. +++ b/tests/src/Functional/BlockFieldTest.php
@@ -156,6 +156,18 @@ class BlockFieldTest extends BrowserTestBase {
+    entity_get_display('node', 'block_field_test', 'default')

    @deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Use EntityDisplayRepositoryInterface::getViewDisplay() instead.

This patch needs a re-roll for Drupal 8.8+

sardara’s picture

sardara CreditAttribution: sardara at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented

@deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Use EntityDisplayRepositoryInterface::getViewDisplay() instead.

It's present from 8.8, but not in 8.7. This module still reports compatibility with ^8.7.7, we shouldn't drop it for a test. Let's change the code to make it work and support 8.7 and 9.0.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
CreditAttribution: tim-diels at Calibrate commented
FileSize
3068281-15-8.9.patch1.77 KB
interdiff_9-15.txt761 bytes

Patch and interdiff provided

e.ryan.schmidt@gmail.com’s picture

e.ryan.schmidt@gmail.com CreditAttribution: e.ryan.schmidt@gmail.com at Elevated Third commented

Just tested the patch in #15 and it works great for me. Thanks!

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented
Status: Needs work » Needs review

Moving to needs review so tests can be added.

  • Berdir committed dd40c4b on 8.x-1.x authored by tim-diels 
    Issue #3068281 by tim-diels: BlockFieldLabelFormatter CacheableMetadata...
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Looks good to me and has a test. Committed.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.