Entering more than one clause along with and modal is not shown on the main page.
How can I make the modal appear in the whole web?

Greetings and thanks

Related issues:

CommentFileSizeAuthor
#12 modal_page-Option_to_create_a_Modal_to_Show_in_All_Pages-3066013-2-D8.patch1.05 KBthalles
#8 Img.png95.22 KBrenatog
#3 Img2.png78.06 KBrenatog
#3 Img.png75.52 KBrenatog

Comments

igonzalez created an issue. See original summary.

renatog’s picture

renatog commented
Status: Active » Postponed (maintainer needs more info)

Hello @igonzalez, how are you?!

Thanks for reporting, but I can't reproduce this error on my machine.

Please, can you put here a step-by-step to reproduce this error?

I'll work on the fix for us.

Best,

renatog’s picture

renatog commented
Issue summary: View changes
StatusFileSize
new Img.png75.52 KB
new Img2.png78.06 KB

If you create 2 modals and configure both to show on front page <front> only the second modal will be shown.

Check the example bellow:

Configuration:

Result:

The current rule is to show the last modal

What's your idea / suggestion ?

renatog’s picture

renatog commented
igonzalez’s picture

igonzalez commented

I'm sorry, I've worked it out.
I would like to know how I can make it look on all the web pages

renatog’s picture

renatog commented

Really makes sense.

This option there is no yet, but it's a good Feature Request.

We can work on that

renatog’s picture

renatog commented
Title: Dont show in front » Option to create a Modal to Show in All Pages
Category: Bug report » Feature request
Priority: Major » Normal
Status: Postponed (maintainer needs more info) » Active
renatog’s picture

renatog commented
StatusFileSize
new Img.png95.22 KB

Suggestion to it:

We can leave this field blank to show the modal in all pages.

What do you think, @thalles?

@igonzalez thanks for your suggestion.

P.s. All patches are welcome

Good Week.

Best,

renatog’s picture

renatog commented
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

The suggestion is really good!
But, I think the best solution would be one code like us , because a field blank is for inactive modal.

What you think @RenatoG?

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Active » Needs work
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new modal_page-Option_to_create_a_Modal_to_Show_in_All_Pages-3066013-2-D8.patch1.05 KB

Hello @RenatoG and @igonzalez!
Follow the patch, that add the new feature, can you test for me?

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Issue summary: View changes
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Version: 8.x-2.4 » 8.x-2.x-dev
renatog’s picture

renatog commented
Status: Needs review » Reviewed & tested by the community

Really works good!

Go ahead Thalles!

Keep pushing, dude

renatog’s picture

renatog commented

After that, we can create a new release for this.

What do you think?

  • thalles authored 3a72acd on 8.x-2.x 
    Issue #3066013 by thalles, RenatoG, igonzalez: Option to create a Modal...
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.