According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

CommentFileSizeAuthor
#2 eb_upload_extract-info-3065225-2.patch358 bytesalonaoneill

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

alonaoneill commented
Assigned: alonaoneill » Unassigned
Status: Active » Needs review
StatusFileSize
new eb_upload_extract-info-3065225-2.patch358 bytes
Willtg’s picture

Willtg commented
Status: Needs review » Reviewed & tested by the community

Code looks good. The dependency namespacing aligns with Drupal documentation standards.
Marking as RTBC
Thank you for working on the module!

  • Ericmaster committed aa56f16 on 8.x-1.x 
    Issue #3065225 by alonaoneill,Willtg: Fix dependency namespacing in ....
ericmaster’s picture

ericmaster commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch, just committed to dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.