Related to #2125611: VAT rounding flawed in some countries, rounding should round up instead of down.

CommentFileSizeAuthor
#3 commerce_vat-fix-rounding-3058151-3.patch2.22 KBjsacksick
#2 commerce_vat-n3058151-2.patch485 bytesdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new commerce_vat-n3058151-2.patch485 bytes

This was written by ndeet.

jsacksick’s picture

jsacksick commented
StatusFileSize
new commerce_vat-fix-rounding-3058151-3.patch2.22 KB

I actually think commerce_vat_rate_round_amount() should call commerce_currency_round() which passes the right precision to round() according to the currency and also take into account the rounding step.

dwkitchen’s picture

dwkitchen commented
Status: Needs review » Fixed

  • dwkitchen committed 9b2d4d5 on 7.x-1.x authored by jsacksick 
    Issue #3058151 by DamienMcKenna, jsacksick: Make rounding round up...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Sadly this introduced a regression, see follow-up: #3265944: Order total and vat total different by one cent