Issue fork fotorama_gallery-3057505

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

meickol created an issue. See original summary.

meickol’s picture

meickol
He/His
commented
Version: 8.x-2.0-rc1 » 3.0.0

pmagunia made their first commit to this issue’s fork.

pmagunia opened merge request !1

jmagunia’s picture

jmagunia
Primary language English
Location Philadelphia 🇺🇸
commented
Status: Active » Needs review
meickol’s picture

meickol
He/His
commented

Thanks for your MR @pmagunia I made some updates to improve your work. Please take a look.

jmagunia’s picture

jmagunia
Primary language English
Location Philadelphia 🇺🇸
commented

Thanks for taking the time to review @meickol. I haven't tried out your commits but they look alright.

I wasn't sure we needed the ->toString() since none of the other blocks had them, but I guess it won't hurt anything.

meickol’s picture

meickol
He/His
commented

The method Link::fromTextAndUrl() return a link object so is not possible to concadete it to a string. thats why I am calling -toString() method.

jmagunia’s picture

jmagunia
Primary language English
Location Philadelphia 🇺🇸
commented

👍

  • meickol committed 539db09 on 3.0.x authored by pmagunia 
    Issue #3057505: add milliseconds option for autoplay configuration
meickol’s picture

meickol
He/His
commented
Status: Needs review » Fixed
meickol’s picture

meickol
He/His
commented
Status: Fixed » Closed (fixed)