Hello,

I am the maintainer of Entity share. Some months ago you pinged me on https://www.drupal.org/project/entity_share/issues/2873069#comment-12789003.

I have not tested the module yet, but here is my review.

Otherwise this looks good. Nice module :)

Comments

Grimreaper created an issue. See original summary.

dbiscalchin’s picture

dbiscalchin CreditAttribution: dbiscalchin commented

Hi @Grimreaper,

Thank you very much for your review.

I've already created an issue to store the "cron_last_run" variable in state - I did not know the State API. Thank you for the tip!

Regarding the change in pager links, have you already released it?

Regards

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented

Hi @dbiscalchin,

Thanks for your reply.

Yes, the commit for the pager in the issue summary is present in the 8.x-2.0-alpha1 of Entity share.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Version: 8.x-1.x-dev » 8.x-2.x-dev

  • Grimreaper authored 476f1be on 8.x-2.x 
    Issue #3056122 by Grimreaper: Fix Typo and PHPDoc.
  • Grimreaper authored cf40cf7 on 8.x-2.x
    Issue #3056122 by Grimreaper: Remove usage of drupal_set_message.
  • Grimreaper authored da4b28a on 8.x-2.x
    Issue #3056122 by Grimreaper: Add strict_types = 1 at the beginning of...

  • Grimreaper authored 4367572 on 8.x-2.x 
    Issue #3056122 by Grimreaper: Update README.txt
Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Status: Active » Fixed
Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.