According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

CommentFileSizeAuthor
#2 feeds_log-info-3051332-2.patch232 bytesalonaoneill

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

alonaoneill commented
Assigned: alonaoneill » Unassigned
Status: Active » Needs review
StatusFileSize
new feeds_log-info-3051332-2.patch232 bytes

I uploaded a patch that fixs dependency namespacing in the .info.yml file.
Thanks!

Willtg’s picture

Willtg commented
Status: Needs review » Reviewed & tested by the community

Code looks good. The dependency name-spacing aligns with Drupal documentation standards.
Marking as RTBC
Thank you for working on the module!

  • Anybody committed d782791 on 2.x 
    Issue #3051332 by alonaoneill, Willtg, Anybody: Dependency namespacing...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Thanks, fixed!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 8.x-1.x-dev » 2.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.