Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.We have a site where you are allowed to create carts that you pay for (using order type default) and orders of type "reservation", where you physically go to the store and pick it up and pay.
So, let's say a user (logged in) has one regular cart with "item 1" in it.
Then in another tab (not logged in) the same person creates a reservation order with "item 2". They decide to log in. I would expect they end up with 2 orders now (one was the stored one, with "item 1", and the other one is the reservation order with "item 2").
So, I would like commerce combine carts to combine carts only of the same type. Would you accept a patch doing this?
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 3046115.patch | 2.67 KB | eiriksm |
Comments
Comment #2
replicaobscuraI agree with your reasoning and approach. I would really appreciate a patch to resolve this issue. Thanks for your report and assistance in resolving the issue!
Comment #3
eiriksmPatch attached
Comment #4
replicaobscuraI think this looks good to me, but I'm curious if anyone else has had a chance to test it in other configurations. I will install and review this myself and get it merged in ASAP too. Thanks for the patch!
Comment #5
replicaobscuraAlmost forgot that I was going to merge in your other patch for creating the test first. I'll get that done and then return to this ASAP.
Comment #6
soliyappan commentedI tested this patch. It's working as expected.
Thanks for the patch.
Comment #7
replicaobscuraCan we get some more testing on this now that several other patches have been merged into the module? I'd like to get this merged ASAP but would love for it to be RTBC first.
Comment #9
replicaobscuraThis has been pushed to dev now (I also removed the old getMainCart method since it wasn't called by anything anymore).