From the comment I made in the core issue (#2976861: add an entity Links handler, to provide menu links/tasks/actions for entity types):
One interesting note: This code currently always generates a Delete local task.
However, core only provides a Delete local task for content entities. Delete local tasks for config entities were explicitly removed in #1834002: Configuration delete operations are all over the place. I am guessing that we don't want to revert that conclusion. So we should either define the Delete local task only for content entity types, or never.
So, our DefaultEntityLocalTaskProvider should either generate the Delete local task for content entities only, or never.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 3044371-4-stop-generating-delete-tasks.patch | 2.52 KB | bojanz |
Comments
Comment #2
tstoecklerSo I don't have any strong opinion on this either way. I've always found them weird in core and thought I was being consistent with core. Wasn't aware of the subtleties.
Comment #3
bojanz commentedUpdating title to clarify solution.
Reading through the core issue, the change was made to config entities only because it was confirmed that content entities no longer had the problem (I do think the problem has reappeared since). But the consensus was that the same fix should be applied to both kinds of entities. Both have a Delete link in the footer, and that is enough.
Comment #4
bojanz commentedComment #6
bojanz commentedCommitted.