From the comment I made in the core issue (#2976861: add an entity Links handler, to provide menu links/tasks/actions for entity types):

One interesting note: This code currently always generates a Delete local task.

However, core only provides a Delete local task for content entities. Delete local tasks for config entities were explicitly removed in #1834002: Configuration delete operations are all over the place. I am guessing that we don't want to revert that conclusion. So we should either define the Delete local task only for content entity types, or never.

So, our DefaultEntityLocalTaskProvider should either generate the Delete local task for content entities only, or never.

Comments

bojanz created an issue. See original summary.

tstoeckler’s picture

So I don't have any strong opinion on this either way. I've always found them weird in core and thought I was being consistent with core. Wasn't aware of the subtleties.

bojanz’s picture

Title: Clarify when the Delete local task should be generated » Stop generating the Delete local task

Updating title to clarify solution.

Reading through the core issue, the change was made to config entities only because it was confirmed that content entities no longer had the problem (I do think the problem has reappeared since). But the consensus was that the same fix should be applied to both kinds of entities. Both have a Delete link in the footer, and that is enough.

bojanz’s picture

Status: Active » Needs review
StatusFileSize
new2.52 KB

  • bojanz committed a25023d on 8.x-1.x
    Issue #3044371 by bojanz: Stop generating the Delete local task
    
bojanz’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.