Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
drupal-check results on commit hash:
source : [git] https://git.drupal.org/project/eva 1d6625fbbf201968804208e819366a1e14860884
source : http://cgit.drupalcode.org/eva
------ ------------------------------------------------------------
Line eva.module
------ ------------------------------------------------------------
161 Call to deprecated method entityManager() of class Drupal.
------ ------------------------------------------------------------
------ -------------------------------------------------
Line src/Plugin/views/display/Eva.php
------ -------------------------------------------------
152 Call to deprecated method checkPlain() of class
Drupal\Component\Utility\SafeMarkup.
152 Call to method checkPlain() of deprecated class
Drupal\Component\Utility\SafeMarkup.
------ -------------------------------------------------
[ERROR] Found 3 errors
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #19 | 3042832-19.patch | 663 bytes | mrinalini9 |
| #13 | interdiff_10-13.txt | 563 bytes | vsujeetkumar |
| #13 | 3042832-13.patch | 4.6 KB | vsujeetkumar |
| #10 | eva-remove-deprecated-3042832-10.patch | 4.16 KB | wrd |
| #7 | eva-remove-deprecated-3042832-7.patch | 3.86 KB | ahebrank |
Comments
Comment #2
ahebrank commentedComment #3
vuilAbout the patch of #2:
@ahebrank
Why you use
service('entity_field.manager')instead ofservice('entity_type.manager')?Comment #4
vuilI set the issue's status to Needs work because it is fail to apply on tests.
Comment #5
ahebrank commentedclearCachedFieldDefinitions() is not in entity type manager; see https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21...
Rerolling without the fuzz.
Comment #6
ahebrank commentedTrying again with core_version_requirement.
Comment #7
ahebrank commentedAdd the missing ER match_limit config in the test module.
Comment #8
ahebrank commentedComment #9
micahw156Patch looks good visually, applied cleanly. Verified my EVA views still work.
Comment #10
wrd commentedWhile the test module had its core_version_requirement set, the main module did not. This patch rectifies that -- assuming that the module is otherwise D9-ready based. If that's not the case, and the core_version_requirement *shouldn't* be set yet, then my apologies and please disregard.
Comment #12
gaëlgDrupal-check is OK with latest patch:
But the automated test above failed with this message:
So I guess some work is still needed.
Comment #13
vsujeetkumar commentedFixed the tests, Please review.
Comment #14
vuilComment #16
ahebrank commentedComment #17
jurgenhaas@ahebrank sorry for re-opening this. There is also the
core: 8.xentry in eva.info.yml and eva_test.info.yml which needs to be removed in order to be able installing EVA on Drupal 9.Comment #18
mrinalini9 commentedComment #19
mrinalini9 commentedAdded patch by removing
core: 8.xentry in eva.info.yml and eva_test.info.yml file as mentioned in #17, please review.Comment #20
jurgenhaasLooking good, thanks @mrinalini9
Comment #21
ahebrank commentedI think it's good the way it is -- the main effect of removing the 'core' key is to make the module incompatible with 8.7 (https://www.drupal.org/node/3070687), which shouldn't be necessary.
I was able to spin up a D9 container and install eva:2.1 without a problem but let me know if there's a specific issue
Comment #22
jurgenhaasYou're right. If the core support is generally
^8 | ^9, then the core key can be still provided. Only if core support is^8.8 | ^9then that core key would have to be removed.