If I have an entity where I have overridden a particular value, that value will not hold the next time a migration is run if the field I set isn't included in the source. For example if I have an entity with a 'phone' field and I select that as an override field and assign it a value of '555-555-5555'. If I then run a migration and do not pass 'phone' as a field in the requested xml, the phone field is added as an empty destination. The migration code then sets all empty destinations to be NULL. If a field is set as a migration override it should probably be removed as an empty destination so we hold on to whatever value was originally set and not replace it with NULL.

CommentFileSizeAuthor
#8 interdiff.3040654.6-8.txt4.34 KBmikelutz
#8 3040654-8.migrate_override.Overridden-fields-set-to-NULL-if-not-present-in-source.patch5.82 KBmikelutz
#8 3040654-7.TEST_ONLY.patch3.23 KBmikelutz
#6 interdiff.3040654.4-6.txt601 bytesmikelutz
#6 3040654-6.migrate_override.Overridden-fields-set-to-NULL-if-not-present-in-source.patch3.07 KBmikelutz
#4 3040654-4.migrate_override.Overridden-fields-set-to-NULL-if-not-present-in-source.patch3.14 KBAngryWookie
#2 3040654-2.migrate_override.Overridden-fields-set-to-NULL-if-not-present-in-source.patch1.71 KBmikelutz

Comments

AngryWookie created an issue. See original summary.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
StatusFileSize
new 3040654-2.migrate_override.Overridden-fields-set-to-NULL-if-not-present-in-source.patch1.71 KB

Starter patch. Needs tests

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Active » Needs work
Issue tags: +Needs tests
AngryWookie’s picture

AngryWookie commented
StatusFileSize
new 3040654-4.migrate_override.Overridden-fields-set-to-NULL-if-not-present-in-source.patch3.14 KB

Wrote test that will fail before this issue is fixed.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented 
  1. +++ b/tests/src/Kernel/OverrideTest.php
@@ -23,9 +23,11 @@ class OverrideTest extends MigrateOverrideTestBase {
+    $this->config->set('entities.node.test_type.fields.missing', OverrideManagerServiceInterface::FIELD_OVERRIDEABLE);

    Should be 'entities.node.test_type.fields.field_test_missing' 

  2. +++ b/tests/src/Kernel/OverrideTest.php
@@ -109,5 +111,34 @@ class OverrideTest extends MigrateOverrideTestBase {
   }
-

    Missing blank line before function 

  3. +++ b/tests/src/Kernel/OverrideTest.php
@@ -109,5 +111,34 @@ class OverrideTest extends MigrateOverrideTestBase {
+  }
 }

    Missing blank line after function

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3040654-6.migrate_override.Overridden-fields-set-to-NULL-if-not-present-in-source.patch3.07 KB
new interdiff.3040654.4-6.txt601 bytes

Test patch

Status: Needs review » Needs work

The last submitted patch, 6: 3040654-6.migrate_override.Overridden-fields-set-to-NULL-if-not-present-in-source.patch, failed testing. View results

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3040654-7.TEST_ONLY.patch3.23 KB
new 3040654-8.migrate_override.Overridden-fields-set-to-NULL-if-not-present-in-source.patch5.82 KB
new interdiff.3040654.6-8.txt4.34 KB

The last submitted patch, 8: 3040654-7.TEST_ONLY.patch, failed testing. View results

  • mikelutz authored 01e3e7b on 8.x-1.x 
    Issue #3040654 by mikelutz, AngryWookie: Overridden fields set to NULL...
mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Needs review » Fixed
mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Fixed » Needs work

  • mikelutz committed b30450a on 8.x-1.x 
    Revert "Issue #3040654 by mikelutz, AngryWookie: Overridden fields set...

  • mikelutz committed 4f40c6f on 8.x-1.x authored by AngryWookie 
    Issue #3040654 by mikelutz, AngryWookie: Overridden fields set to NULL...
mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.